feat(gitlab/mergerequest): configure additional fields during mr creation #5094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olblak
reviewed
May 12, 2025
|
It looks good to me, I am wondering why the test is failing as it doesn't look like the usual flaky e2e tests |
olblak
reviewed
May 13, 2025
olblak
reviewed
May 13, 2025
|
I had a quick look to the drone/go-scm library and there, they always return the response, which is useful to get additional information https://github.com/drone/go-scm/blob/a515870a3931d01562ab61723891462134a3277f/scm/driver/gitlab/pr.go#L80 Especially when the request fails for situation like authentication issues that are not catch by the err handling |
olblak
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support of setting additional Gitlab MR options during it's creation:
labelsreviewersassigneessquashremoveSourceBranchAdditional Information
All interaction with Gitlab in gitlab/mergerequest action have been rewritten using gitlab-api-client-go libarary