fix(yaml): improve target change detection logic #4864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring to old value before deciding whether to skip the update
olblak
reviewed
Apr 22, 2025
|
Thanks for the pullrequest and the test |
olblak
reviewed
Apr 24, 2025
olblak
reviewed
Apr 24, 2025
olblak
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging some issues I am having over at https://github.com/mecha-hq/images/ (eg: https://github.com/mecha-hq/images/actions/runs/14562281638/job/40847058933) I came across two issues:
This PR aims at fixing the second issue by introducing a check against the stringified value of the value, and not just the "raw" one.
I discussed some of my findings at #4855
Thank you for considering this!