Skip to content

Conversation

olblak
Copy link
Member

@olblak olblak commented Apr 8, 2025

Fix a regression where Updatecli doesn't detect anymore if the udash config file exist.
errors.Is(err, fs.ErrNotExist) supersede os.IsNotExist(err)

The last one only check if the error is is not exist while the first function checks if err contain is not exist

Test

To test this pull request, you can run the following commands:

cd <to_package_directory>
go test

Additional Information

Checklist

  • I have updated the documentation via pull request in website repository.

Tradeoff

Potential improvement

@olblak olblak added bug Something isn't working udash All things related to Udash labels Apr 8, 2025
@olblak olblak merged commit fdaf4fa into updatecli:main Apr 9, 2025
6 checks passed
@olblak olblak changed the title fix(udash): correctly handle error if udash doesn't exist fix(udash): correctly handle error if udash config doesn't exist Apr 14, 2025
@olblak olblak deleted the removeDeprecatedErrorHandlingInCore branch May 2, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working udash All things related to Udash
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant