Skip to content

Conversation

Myestery
Copy link
Contributor

@Myestery Myestery commented Sep 18, 2024

Description

This pull request helps to fix the hanging issue that occurs in nextjs apps when lint is run.
The cause was that due to the way we changed the eslint command in all packages, we now have to specify blacklist instead of whitelisted folders. My last PR unfortunately did not cater for the .next folder and it caused eslint to hang when run on nextjs packages.

Issues

Fixes #14564
Refs #

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@cla-bot cla-bot bot added the cla-signed label Sep 18, 2024
@Myestery Myestery mentioned this pull request Sep 18, 2024
@julien51
Copy link
Member

ha! great catch here @Myestery !

@julien51 julien51 merged commit 75ef6ae into unlock-protocol:master Sep 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eslint cleanup
2 participants