Skip to content

Eslint cleanup 2 #14603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Sep 13, 2024
Merged

Eslint cleanup 2 #14603

merged 17 commits into from
Sep 13, 2024

Conversation

Myestery
Copy link
Contributor

@Myestery Myestery commented Sep 13, 2024 •
edited
Loading

Description

Issues

Fixes #14564 (comment)
Refs #14564 (comment)

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Ensure consistent eslint rules across all packages, also ensure commands are same and reused in all package.jsons

Myestery and others added 14 commits September 11, 2024 17:42
@Myestery
feat (lint): synchronize eslint rules
ec560e5
@Myestery
feat (lint): synchronize eslint rules
b38b4b3
@Myestery
feat (lint): synchronize eslint rules
0d9f6e0
@Myestery
feat(lint): Synchronize eslint rules and add evm-address-to-checksumm…
7370c64 
…ed warning
@Myestery
feat(lint): Synchronize eslint rules and update evm-address-to-checks…
13c885d 
…ummed warning

This commit synchronizes the eslint rules and updates the evm-address-to-checksummed warning. It also fixes the formatting of recipient and userAddress variables to use checksummed addresses.

Fixes unlock-protocol#14592
@Myestery
refactor(eslint-config): Remove unnecessary eslint-disable comments a…
06fa4eb 
…nd unused imports
@julien51 @Myestery
feat(unlock-app) timezone set by default based on location (unlock-pr…
12c1ace 
…otocol#14594)

timezone set by deafault based on location
@julien51 @Myestery
fix(locksmit): fixed relayer API
46bee91
@0xTxbi @Myestery
fix(packages/ui): Improve AddressInput UX (unlock-protocol#14596)
968ced2 
improve ux for resolving address or name inputs
@0xTxbi @Myestery
fix(unlock-app): Attendees specific view (unlock-protocol#14589)
bc80642 
* add UpdateEmailModal component

* strip attendee specific actions from locks' view

* strip unnwanted metadata and add specific event actions to attendees' view

* linting

* update lock settings metadata card to include email actions
@julien51 @Myestery
docs: adding UP to title
b349220
@julien51 @Myestery
docs: adding tags to the UP token page
e4fdb2f
@clemsos @Myestery
fix(ci): correct github comment proxy deployment URL (unlock-protocol…
6d92dc7 
…#14598)
@Myestery
Merge branch 'master' into eslint-cleanup
1cb1d3b
@cla-bot cla-bot bot added the cla-signed label Sep 13, 2024
@Myestery Myestery marked this pull request as ready for review September 13, 2024 15:28
@julien51
Copy link
Member

Thanks!

@Myestery
Copy link
Contributor Author

Looks like we have a nextjs error unrelated to this PR

@julien51
Copy link
Member

ok let's try again then!

@julien51 julien51 merged commit e45d303 into unlock-protocol:master Sep 13, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eslint cleanup
4 participants
@Myestery @julien51 @0xTxbi @clemsos