Skip to content

Conversation

julien51
Copy link
Member

Description

Based on feedback received by Snax (PizzaDAO), we are now using the location to determine the timezone.
As a result we are not showing the timezone input when the event is in person.

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@cla-bot cla-bot bot added the cla-signed label Sep 11, 2024
@julien51
Copy link
Member Author

@julien51 julien51 requested a review from 0xTxbi September 11, 2024 15:32
Copy link
Member

@0xTxbi 0xTxbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic! lgtm!

@julien51 julien51 merged commit 7f01e9b into master Sep 11, 2024
13 checks passed
Myestery pushed a commit to Myestery/unlock that referenced this pull request Sep 12, 2024
julien51 added a commit that referenced this pull request Sep 12, 2024
* feat (lint): synchronize eslint rules

* feat (lint): synchronize eslint rules

* feat (lint): synchronize eslint rules

* feat(lint): Synchronize eslint rules and add evm-address-to-checksummed warning

* feat(lint): Synchronize eslint rules and update evm-address-to-checksummed warning

This commit synchronizes the eslint rules and updates the evm-address-to-checksummed warning. It also fixes the formatting of recipient and userAddress variables to use checksummed addresses.

Fixes #14592

* refactor(eslint-config): Remove unnecessary eslint-disable comments and unused imports

* feat(unlock-app) timezone set by default based on location (#14594)

timezone set by deafault based on location

* fix(locksmit): fixed relayer API

* fix(packages/ui): Improve `AddressInput` UX (#14596)

improve ux for resolving address or name inputs

* fix(unlock-app): Attendees specific view (#14589)

* add UpdateEmailModal component

* strip attendee specific actions from locks' view

* strip unnwanted metadata and add specific event actions to attendees' view

* linting

* update lock settings metadata card to include email actions

* docs: adding UP to title

* docs: adding tags to the UP token page

* fix(ci): correct github comment proxy deployment URL (#14598)

---------

Co-authored-by: Julien Genestoux <julien.genestoux@gmail.com>
Co-authored-by: txbì <46839250+0xTxbi@users.noreply.github.com>
Co-authored-by: Clément Renaud <clement@unlock-protocol.com>
julien51 added a commit that referenced this pull request Sep 13, 2024
* feat (lint): synchronize eslint rules

* feat (lint): synchronize eslint rules

* feat (lint): synchronize eslint rules

* feat(lint): Synchronize eslint rules and add evm-address-to-checksummed warning

* feat(lint): Synchronize eslint rules and update evm-address-to-checksummed warning

This commit synchronizes the eslint rules and updates the evm-address-to-checksummed warning. It also fixes the formatting of recipient and userAddress variables to use checksummed addresses.

Fixes #14592

* refactor(eslint-config): Remove unnecessary eslint-disable comments and unused imports

* feat(unlock-app) timezone set by default based on location (#14594)

timezone set by deafault based on location

* fix(locksmit): fixed relayer API

* fix(packages/ui): Improve `AddressInput` UX (#14596)

improve ux for resolving address or name inputs

* fix(unlock-app): Attendees specific view (#14589)

* add UpdateEmailModal component

* strip attendee specific actions from locks' view

* strip unnwanted metadata and add specific event actions to attendees' view

* linting

* update lock settings metadata card to include email actions

* docs: adding UP to title

* docs: adding tags to the UP token page

* fix(ci): correct github comment proxy deployment URL (#14598)

---------

Co-authored-by: Julien Genestoux <julien.genestoux@gmail.com>
Co-authored-by: txbì <46839250+0xTxbi@users.noreply.github.com>
Co-authored-by: Clément Renaud <clement@unlock-protocol.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants