fix(unlock-app): Attendees specific view #14589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ha! Let's keep the email setting button on the Lock view please because it can be used for other kinds of locks (not just the event ones) |
got it! |
|
new view with the e-mail settings being reverted |
julien51
approved these changes
Sep 12, 2024
Myestery
pushed a commit
to Myestery/unlock
that referenced
this pull request
Sep 12, 2024
* add UpdateEmailModal component * strip attendee specific actions from locks' view * strip unnwanted metadata and add specific event actions to attendees' view * linting * update lock settings metadata card to include email actions
julien51
added a commit
that referenced
this pull request
Sep 12, 2024
* feat (lint): synchronize eslint rules * feat (lint): synchronize eslint rules * feat (lint): synchronize eslint rules * feat(lint): Synchronize eslint rules and add evm-address-to-checksummed warning * feat(lint): Synchronize eslint rules and update evm-address-to-checksummed warning This commit synchronizes the eslint rules and updates the evm-address-to-checksummed warning. It also fixes the formatting of recipient and userAddress variables to use checksummed addresses. Fixes #14592 * refactor(eslint-config): Remove unnecessary eslint-disable comments and unused imports * feat(unlock-app) timezone set by default based on location (#14594) timezone set by deafault based on location * fix(locksmit): fixed relayer API * fix(packages/ui): Improve `AddressInput` UX (#14596) improve ux for resolving address or name inputs * fix(unlock-app): Attendees specific view (#14589) * add UpdateEmailModal component * strip attendee specific actions from locks' view * strip unnwanted metadata and add specific event actions to attendees' view * linting * update lock settings metadata card to include email actions * docs: adding UP to title * docs: adding tags to the UP token page * fix(ci): correct github comment proxy deployment URL (#14598) --------- Co-authored-by: Julien Genestoux <julien.genestoux@gmail.com> Co-authored-by: txbì <46839250+0xTxbi@users.noreply.github.com> Co-authored-by: Clément Renaud <clement@unlock-protocol.com>
julien51
added a commit
that referenced
this pull request
Sep 13, 2024
* feat (lint): synchronize eslint rules * feat (lint): synchronize eslint rules * feat (lint): synchronize eslint rules * feat(lint): Synchronize eslint rules and add evm-address-to-checksummed warning * feat(lint): Synchronize eslint rules and update evm-address-to-checksummed warning This commit synchronizes the eslint rules and updates the evm-address-to-checksummed warning. It also fixes the formatting of recipient and userAddress variables to use checksummed addresses. Fixes #14592 * refactor(eslint-config): Remove unnecessary eslint-disable comments and unused imports * feat(unlock-app) timezone set by default based on location (#14594) timezone set by deafault based on location * fix(locksmit): fixed relayer API * fix(packages/ui): Improve `AddressInput` UX (#14596) improve ux for resolving address or name inputs * fix(unlock-app): Attendees specific view (#14589) * add UpdateEmailModal component * strip attendee specific actions from locks' view * strip unnwanted metadata and add specific event actions to attendees' view * linting * update lock settings metadata card to include email actions * docs: adding UP to title * docs: adding tags to the UP token page * fix(ci): correct github comment proxy deployment URL (#14598) --------- Co-authored-by: Julien Genestoux <julien.genestoux@gmail.com> Co-authored-by: txbì <46839250+0xTxbi@users.noreply.github.com> Co-authored-by: Clément Renaud <clement@unlock-protocol.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the
unlock-appby moving attendee-specific actions from the lock details view to the attendee view, ensuring context-appropriate behavior.Screengrabs:
Issues
Fixes #14579
Refs #14579
Checklist:
Release Note Draft Snippet