Fix warnings on log level variables on running sbt test command #100
Conversation
|
Thank you @tlm365 ! |
build.sbt
Outdated
| @@ -46,6 +46,8 @@ lazy val commonSettings = Seq( | |||
| } | |||
| ) | |||
|
|
|||
| Global / excludeLintKeys ++= Set(Compile / logLevel) | |||
There was a problem hiding this comment.
I believe removing the keys is better rather than excluding them from lint. I don't think there should be any change in behaviour.
There was a problem hiding this comment.
@vikrantpuppala yeah, that's one of the solutions, but I chose to handle it during linting because I wasn't sure about the intended use of that key. If it's fine to remove, I will update the commit.
There was a problem hiding this comment.
I played around with this today and noticed no issues with the server and cli output post removal of these settings. I think it's better to have these removed rather than ignoring in lint.
|
@vikrantpuppala @tlm365 is this PR ready? |
I think it's fine. But @vikrantpuppala is concerned that removing lint the key |
Signed-off-by: Tai Le Manh <manhtai.lmt@gmail.com>
PR Checklist
Description of changes
Resolves #91.
This issue comes from the key linting added in sbt 1.4.0, which warns keys are used by some tasks but not by others. In our case,
Compile / logLevelis used incli,client,serverbut not inapiDocs.