ICU-22721 Delete obsolete __STRICT_ANSI__ workaround for MinGW #3003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was originally added in the year 2004 for ICU-3854 but is no longer needed with contemporary versions of MinGW where it instead as of GCC 14 causes this problem: __STRICT_ANSI__ seems to have been undefined; this is not supported.
lazka
added a commit
to lazka/MINGW-packages
that referenced
this pull request
Jun 20, 2024
icu is built without gnu extensions but in various places undefs __STRICT_ANSI__ which enables code in the libstdc++ that depends on gnu extensions. We worked around this by enabling the specific extensions this required but this upstream patch is better, to not touch __STRICT_ANSI__ in the first place: unicode-org/icu#3003
lazka
added a commit
to lazka/MINGW-packages
that referenced
this pull request
Jun 20, 2024
icu is built without gnu extensions but in various places undefs __STRICT_ANSI__ which enables code in the libstdc++ that depends on gnu extensions. We worked around this by enabling the specific extensions this required but this upstream patch is better, to not touch __STRICT_ANSI__ in the first place: unicode-org/icu#3003
This was referenced Sep 27, 2024
Mytherin
added a commit
to duckdb/duckdb
that referenced
this pull request
Oct 3, 2024
… builds (#14154) These two changes fix builds that don't use cmake unity described in issue #14151 1. Remove header inclusion guard in windows_undefs.hpp to insure certain Win32 macros are always undefined - this is okay because all these #undef are guarded by `#ifdef WIN32` 2. Copy deletion of ICU undefine of `__STRICT_ANSI__` from ICU upstream that conflicts with GCC-14 header files - this duplicates unicode-org/icu#3003 - it would be better to pull the latest ICU in but ICU is used in a customized way that would require more effort - also looks like fix won't be released till ICU 75.2 which is not yet released - https://unicode-org.atlassian.net/browse/ICU-22721
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally added in the year 2004 for ICU-3854 but is no longer needed with contemporary versions of MinGW where it instead as of GCC 14 causes this problem:
__STRICT_ANSI__seems to have been undefined; this is not supported.Checklist