feat(http): Standardise HTTP inbound & outbound panels #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note Clouddriver also has some I've left these for now. Ultimately we should add recording rules to reduce dashboard query time load on Prometheus. |
`controller_invocations_total` is an enhanced version of Springs
`http_server_requests` metric with nicer label formatting and other
differences.
`okhttp_requests_seconds_{count|max|sum}` is for outbound requests.
As all Java services expose these metrics pull them out to a separate
file that we can import accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3
controller_invocations_totalis an enhanced version of Springshttp_server_requestsmetric with nicer label formatting and otherdifferences.
okhttp_requests_seconds_{count|max|sum}is for outbound requests.As all Java services expose these metrics pull them out to a separate
file that we can import accordingly.