Skip to content

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Apr 7, 2025

Summary by CodeRabbit

  • Bug Fixes
    • Increased memory allocation to resolve memory-related issues.
  • Chores
    • Updated the WebAssembly build process for enhanced flexibility.
    • Introduced a dedicated configuration to manage memory settings and stack size.
    • Updated Node.js version in the configuration for improved environment compatibility.

Copy link

changeset-bot bot commented Apr 7, 2025

🦋 Changeset detected

Latest commit: 418a03c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sh-syntax Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codesandbox-ci bot commented Apr 7, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

coderabbitai bot commented Apr 7, 2025

Warning

Rate limit exceeded

@JounQin has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 7 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 30bbd5d and 418a03c.

⛔ Files ignored due to path filters (1)
  • main.wasm is excluded by !**/*.wasm
📒 Files selected for processing (2)
  • .codesandbox/ci.json (1 hunks)
  • target.json (1 hunks)

Walkthrough

The pull request introduces two new files and a modification to an existing configuration file. A change file, chatty-lizards-retire.md, is added with a memory usage fix note. The package.json file is updated to modify the build script for WebAssembly, now referencing a new configuration file. A new target.json file is introduced, defining inherited settings and linker flags for memory and stack configurations to be used during the WebAssembly build.

Changes

File(s) Change Summary
.changeset/chatty-lizards-retire.md New file added containing a patch note: fix: increase memory usage.
package.json Modified the wasm script command to use target configuration from ./target.json instead of a hard-coded target.
target.json New file added defining configuration with an inherits array (including "wasm") and ldflags for initial memory, maximum memory, and stack size settings.
.codesandbox/ci.json Updated Node.js version from "16" to "20".

Sequence Diagram(s)

sequenceDiagram
    participant Dev as Developer
    participant Pkg as package.json
    participant Build as tinygo build
    participant Target as target.json
    participant WASM as main.wasm

    Dev->>Pkg: Run "npm run wasm"
    Pkg->>Build: Execute build command with target "./target.json"
    Build->>Target: Load build configurations (inherits, ldflags)
    Build->>WASM: Generate WebAssembly module with specified settings
Loading

Poem

Hoppin' through lines of code so new,
A memory fix with a vibrant view!
Configs and flags, aligned just right,
Building WASM with all my might.
Leaping high with each change in sight!
🐇💻


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

pkg-pr-new bot commented Apr 7, 2025

Open in StackBlitz

npm i https://pkg.pr.new/sh-syntax@111

commit: 418a03c

Copy link
Contributor

github-actions bot commented Apr 7, 2025

size-limit report 📦

Path Size
lib/browser.js 121 B (0%)
lib/index.js 378 B (0%)

Copy link
Contributor

github-actions bot commented Apr 7, 2025

📊 Package size report   0.7%↑

File Before After
main.wasm 780.1 kB 0.7%↑785.7 kB
package.json 3.6 kB 0.2%↑3.6 kB
Total (Includes all files) 834.6 kB 0.7%↑840.2 kB
Tarball size 306.1 kB 0.07%↑306.3 kB
Unchanged files
File Size
index.d.cts 62 B
lib/browser.d.ts 95 B
lib/browser.js 130 B
lib/browser.js.map 171 B
lib/index.cjs 8.1 kB
lib/index.d.ts 709 B
lib/index.js 818 B
lib/index.js.map 950 B
lib/processor.d.ts 707 B
lib/processor.js 3.3 kB
lib/processor.js.map 3.5 kB
lib/shim.d.ts 11 B
lib/shim.js 279 B
lib/shim.js.map 342 B
lib/types.d.ts 7.1 kB
lib/types.js 157 B
lib/types.js.map 243 B
LICENSE 1.1 kB
README.md 7.1 kB
vendors/wasm_exec.cjs 16.0 kB
vendors/wasm_exec.d.cts 98 B

🤖 This report was automatically generated by pkg-size-action

Copy link

sonarqubecloud bot commented Apr 7, 2025

Copy link

codecov bot commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.25%. Comparing base (63e69dc) to head (418a03c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   96.25%   96.25%           
=======================================
  Files           4        4           
  Lines          80       80           
  Branches       32       32           
=======================================
  Hits           77       77           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JounQin JounQin merged commit 8b93f9a into main Apr 7, 2025
38 checks passed
@JounQin JounQin deleted the fix/memory branch April 7, 2025 22:26
@github-actions github-actions bot mentioned this pull request Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant