fix: remove buggy module-sync exports field
#453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a26b877 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR removes the buggy "module-sync" exports field from several package.json files to address export configuration issues.
- Removed the "module-sync" field from packages/toml/package.json
- Removed the "module-sync" field from packages/sql/package.json
- Removed the "module-sync" field from packages/sh/package.json, packages/pkg/package.json, and packages/autocorrect/package.json
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/toml/package.json | Removed the "module-sync" export configuration field. |
| packages/sql/package.json | Removed the "module-sync" export configuration field. |
| packages/sh/package.json | Removed the "module-sync" export configuration field. |
| packages/pkg/package.json | Removed the "module-sync" export configuration field. |
| packages/autocorrect/package.json | Removed the "module-sync" export configuration field. |
WalkthroughThe "module-sync" export entry was removed from the Changes
Assessment against linked issues
Possibly related PRs
Poem
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (12)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #453 +/- ##
=======================================
Coverage 85.71% 85.71%
=======================================
Files 10 10
Lines 182 182
Branches 47 47
=======================================
Hits 156 156
Misses 25 25
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 0de2845 in 42 seconds. Click for details.
- Reviewed
75lines of code in5files - Skipped
0files when reviewing. - Skipped posting
13draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/autocorrect/package.json:17
- Draft comment:
Good removal of the buggy module-sync field; exports now include only import and require which aligns with standard practices. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. packages/pkg/package.json:17
- Draft comment:
Module-sync removal here is consistent with the fix; only import and require are exported now. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. packages/sh/package.json:17
- Draft comment:
The removal of the module-sync export from the exports field in this package is correct. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. packages/sql/package.json:17
- Draft comment:
Removing the module-sync export resolves potential conflicts; the change is implemented uniformly. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
5. packages/toml/package.json:22
- Draft comment:
The change removes the problematic module-sync export, which should mitigate the panic reported in issue #452. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, explaining what the change does and its expected impact. It doesn't provide a suggestion, ask for confirmation, or point out a potential issue.
6. packages/autocorrect/package.json:19
- Draft comment:
Removed the non-standard 'module-sync' export field. This cleanup is appropriate as only 'import' and 'require' are needed per Node spec. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, explaining why a change was made. It doesn't provide a suggestion or ask for confirmation about a specific code change. It doesn't align with the rules for good comments.
7. packages/pkg/package.json:19
- Draft comment:
The removal of the 'module-sync' export field is correct; it avoids potential conflicts and aligns with best practices. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, as it praises the removal of a field without providing any actionable feedback or suggestions. It doesn't ask for confirmation or suggest any changes.
8. packages/sh/package.json:19
- Draft comment:
Removing the 'module-sync' field is appropriate. It streamlines exports to only 'import' and 'require', adhering to standards. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, as it simply states that removing the 'module-sync' field streamlines exports. It doesn't provide any actionable feedback or suggestions for improvement.
9. packages/sql/package.json:19
- Draft comment:
The deletion of the 'module-sync' export field is valid. It removes a non-standard field that may have caused issues. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, as it simply states that the deletion of a field is valid and may have caused issues. It does not provide any actionable feedback or suggestions for improvement.
10. packages/toml/package.json:22
- Draft comment:
Removing the 'module-sync' export field here resolves the issue (as seen in issue #452) and maintains proper module exports. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, explaining why a change was made. It doesn't provide a suggestion, ask for confirmation, or point out a potential issue.
11. packages/pkg/package.json:8
- Draft comment:
There appears to be a minor typographical inconsistency in the author field: the email uses '1stg.me' while the website URL uses '1stG.me'. It’s recommended to standardize the casing for consistency. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
12. packages/sh/package.json:5
- Draft comment:
The description in line 5 contains a grammatical error: "also support simple format" should be "also supports simple format" for proper subject-verb agreement. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
13. packages/toml/package.json:12
- Draft comment:
Typographical error: The funding URL in line 12 is set to "https://opencollective.com/unts". Considering the repository owner and other references use "un-ts", you might want to double-check if the URL should be "https://opencollective.com/un-ts". - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_3c4RGehKAHZ2edPA
You can customize 
size-limit report 📦
|
prettier-plugin-autocorrect
prettier-plugin-pkg
prettier-plugin-sql
prettier-plugin-sh
prettier-plugin-toml
commit: |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the only difference I can tell between
prettier-plugin-tomlv2.0.3 vs v2.0.4close #452
related un-ts/pkgr#391
Important
Remove
module-syncexport field frompackage.jsonin multiple packages.module-syncexport field frompackage.jsoninautocorrect,pkg,sh,sql, andtomlpackages.This description was created by
for 0de2845. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit