-
-
Notifications
You must be signed in to change notification settings - Fork 2
fix(core): incorrect typing for cjs
entry
#387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: b71797c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis pull request introduces a patch for the Changes
Sequence Diagram(s)sequenceDiagram
participant C as Consumer
participant CP as Core Package (CJS Entry)
participant L as lib Module (CJS)
C->>CP: require("core")
CP->>L: Redirect to ./lib/index.cjs (with types from index.d.cts)
L-->>CP: Module instance
CP-->>C: Return module instance
sequenceDiagram
participant C as Consumer
participant CP as Core Package (ESM Entry)
participant L as lib Module (ESM)
C->>CP: import { ... } from "core"
CP->>L: Redirect to ./lib/index.js (with types from ./lib/index.d.ts)
L-->>CP: Module instance
CP-->>C: Return module instance
Possibly related PRs
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
packages/core/index.d.ctsOops! Something went wrong! :( ESLint: 9.24.0 Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@1stg/eslint-config' imported from /eslint.config.js 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (6)
⏰ Context from checks skipped due to timeout of 90000ms (3)
🔇 Additional comments (11)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (2)
- package.json: Language not supported
- packages/core/package.json: Language not supported
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #387 +/- ##
======================================
Coverage 9.97% 9.97%
======================================
Files 12 12
Lines 421 421
Branches 184 184
======================================
Hits 42 42
Misses 379 379 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@pkgr/browser
@pkgr/core
@pkgr/es-modules
@pkgr/imagemin
@pkgr/rollup
@pkgr/umd-globals
@pkgr/utils
commit: |
Deploy preview for pkgr ready! ✅ Preview Built with commit b71797c. |
📊 Package size report No changes
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
Summary by CodeRabbit
Bug Fixes
New Features
Chores