Skip to content

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 29, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence Type Update
@types/node (source) ^20.17.28 -> ^22.0.0 age adoption passing confidence devDependencies major
actions/checkout -> 11bd719 action pinDigest
actions/setup-node -> cdca736 action pinDigest
autofix-ci/action -> 2891949 action pinDigest
codecov/codecov-action -> 0565863 action pinDigest
github/codeql-action -> 1b549b9 action pinDigest
yarn (source) 4.7.0 -> 4.8.0 age adoption passing confidence packageManager minor

Release Notes

yarnpkg/berry (yarn)

v4.8.0

Compare Source


Configuration

📅 Schedule: Branch creation - "* 0-3 1 * *" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Summary by CodeRabbit

  • Chores
    • Refined linting configurations to adjust rule enforcement based on the installed tooling version.
    • Updated automation workflows to use fixed versions, ensuring consistency and reliability in CI/CD processes.
    • Upgraded package management and dependency definitions for improved development stability.

Copy link

changeset-bot bot commented Mar 29, 2025

⚠️ No Changeset found

Latest commit: 5f29f8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

coderabbitai bot commented Mar 29, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This update adds a new constant in the ESLint configuration that checks if the installed version is below 9, and conditionally adjusts the behavior of the no-constant-condition rule. Additionally, multiple GitHub workflow files have been modified to reference specific commit hashes for their actions rather than using version tags. The changes also include an upgrade to the Yarn version in the Yarn configuration as well as in the package.json file with a corresponding update to the Node type definitions.

Changes

File(s) Change Summary
.eslintrc.js Introduces the nonLatestEslint constant to conditionally set the no-constant-condition rule (disabled for ESLint <9, error otherwise).
.github/workflows/*.yml Updates multiple workflow files (autofix, ci, codeql, pkg-pr-new, release) to use specific commit hashes for actions like actions/checkout, actions/setup-node, etc.
.yarnrc.yml Updates the yarnPath from yarn-4.7.0.cjs to yarn-4.8.0.cjs.
package.json Increments the packageManager from yarn@4.7.0 to yarn@4.8.0 and updates the @types/node dependency from ^20.17.28 to ^22.0.0.

Sequence Diagram(s)

sequenceDiagram
    participant Config as ESLint Config (.eslintrc.js)
    participant Checker as Version Checker
    Config->>Checker: Read installed ESLint version from package.json
    Checker-->>Config: Return version string
    Config->>Config: Parse version and evaluate if < 9
    alt Version < 9
        Config->>Config: Set no-constant-condition rule to 'off'
    else
        Config->>Config: Set no-constant-condition rule to 'error'
    end
Loading

Poem

I'm a rabbit on a coding spree,
Hopping through configs most merrily.
ESLint checks its version with a twist,
And workflows now have commits on their list.
Yarn leaps ahead with updates so bright,
Celebrating changes deep into the night! 🐇

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

.eslintrc.js

(node:19526) ESLintIgnoreWarning: The ".eslintignore" file is no longer supported. Switch to using the "ignores" property in "eslint.config.js": https://eslint.org/docs/latest/use/configure/migration-guide#ignoring-files
(Use node --trace-warnings ... to show where the warning was created)

Oops! Something went wrong! :(

ESLint: 9.23.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by
https://eslint.org/chat/help to chat with the team.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4587467 and 5f29f8c.

⛔ Files ignored due to path filters (2)
  • .yarn/releases/yarn-4.8.0.cjs is excluded by !**/.yarn/**
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (8)
  • .eslintrc.js (2 hunks)
  • .github/workflows/autofix.yml (2 hunks)
  • .github/workflows/ci.yml (2 hunks)
  • .github/workflows/codeql.yml (1 hunks)
  • .github/workflows/pkg-pr-new.yml (1 hunks)
  • .github/workflows/release.yml (1 hunks)
  • .yarnrc.yml (1 hunks)
  • package.json (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

socket-security bot commented Mar 29, 2025

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@cspotcode/source-map-support@0.8.1 filesystem 0 102 kB cspotcode
npm/@humanwhocodes/config-array@0.11.14 None 0 55.6 kB nzakas
npm/@humanwhocodes/object-schema@2.0.2 None 0 53.3 kB nzakas
npm/@jest/console@29.7.0 None 0 19 kB simenb
npm/@jest/core@29.7.0 unsafe +1 149 kB simenb
npm/@jest/reporters@29.7.0 environment, unsafe 0 115 kB simenb
npm/@jest/test-result@29.7.0 None 0 15.8 kB simenb
npm/@jest/transform@29.7.0 None 0 52.4 kB simenb
npm/@tsconfig/node10@1.0.11 None 0 2.31 kB typescript-deploys
npm/@tsconfig/node12@1.0.11 None 0 2.5 kB typescript-deploys
npm/@tsconfig/node14@1.0.3 None 0 2.39 kB typescript-deploys
npm/@tsconfig/node16@1.0.4 None 0 2.45 kB typescript-deploys
npm/@yarnpkg/core@4.2.1 None +2 1.43 MB arcanis, bestander, cpojer, ...2 more
npm/acorn-walk@8.3.2 None 0 52.4 kB marijn
npm/ansi-escapes@4.3.2 None 0 16.4 kB sindresorhus
npm/arg@4.1.3 None 0 12.9 kB qix
npm/builtin-modules@3.3.0 unsafe 0 4.51 kB sindresorhus
npm/clean-regexp@1.0.0 None 0 8.54 kB samverschueren
npm/create-jest@29.7.0 None 0 15.9 kB simenb
npm/create-require@1.1.1 filesystem, unsafe 0 6.25 kB pi0
npm/diff@4.0.2 None 0 335 kB kpdecker
npm/eslint-compat-utils@0.6.4 filesystem 0 54.1 kB ota-meshi
npm/eslint-mdx@3.3.1 None 0 86.5 kB johno, remcohaszing, timneutkens, ...1 more
npm/eslint-plugin-es-x@7.8.0 None 0 409 kB eslint-community-bot
npm/eslint-plugin-prettier@5.2.5 None +1 112 kB jounqin
npm/eslint-plugin-unicorn@56.0.1 None 0 711 kB sindresorhus
npm/eslint-plugin-yml@1.17.0 None 0 288 kB ota-meshi
npm/eslint@9.22.08.56.0 filesystem +1 3.04 MB eslintbot
npm/estree-util-visit@2.0.0 None 0 22.6 kB wooorm
npm/execa@8.0.1 environment 0 80.1 kB ehmicky
npm/exit@0.1.2 None 0 59.8 kB cowboy
npm/fast-diff@1.3.0 None 0 52.3 kB luin
npm/hermes-eslint@0.27.0 None 0 271 kB hermes-team
npm/hermes-estree@0.27.0 None 0 364 kB hermes-team
npm/hermes-parser@0.27.0 None 0 1.25 MB hermes-team
npm/import-local@3.1.0 None 0 4.66 kB sindresorhus
npm/indent-string@4.0.0 None 0 4.4 kB sindresorhus
npm/is-builtin-module@3.2.1 None 0 3.88 kB sindresorhus
npm/is-path-inside@3.0.3 None 0 4.12 kB sindresorhus
npm/jest-changed-files@29.7.0 environment 0 18.2 kB simenb
npm/jest-cli@29.7.0 None 0 33.8 kB simenb
npm/jest-config@29.7.0 None 0 114 kB simenb
npm/jest-haste-map@29.7.0 environment, filesystem, shell, unsafe 0 121 kB simenb
npm/jest-regex-util@29.6.3 None 0 3.52 kB simenb
npm/jest-resolve-dependencies@29.7.0 None 0 8.92 kB simenb
npm/jest-resolve@29.7.0 environment, unsafe 0 65.7 kB simenb
npm/jest-runner@29.7.0 environment 0 29.6 kB simenb
npm/jest-runtime@29.7.0 unsafe 0 89.2 kB simenb
npm/jest-snapshot@29.7.0 eval 0 83.5 kB simenb
npm/jest-validate@29.7.0 None 0 28.7 kB simenb
npm/jest-watcher@29.7.0 None 0 23.4 kB simenb
npm/jest@29.7.0 None 0 5.01 kB simenb
npm/jsonc-parser@3.3.1 None 0 213 kB vscode-bot
npm/lilconfig@3.1.3 filesystem 0 18 kB antonk52
npm/lint-staged@15.5.0 None 0 0 B
npm/listr2@8.2.5 environment 0 276 kB cenk1cenk2
npm/make-error@1.3.6 None 0 12.4 kB julien-f
npm/memfs@4.17.0 None 0 684 kB streamich
npm/memorystream@0.3.1 None 0 23.2 kB jsbizon
npm/micromark-extension-mdxjs@3.0.0 None 0 14 kB wooorm
npm/min-indent@1.0.1 None 0 2.97 kB thejameskyle
npm/npm-run-all2@7.0.2 environment, filesystem +1 658 kB bret
npm/path-serializer@0.3.4 eval 0 78.7 kB sooniter
npm/pidtree@0.6.0 shell 0 23.1 kB simonepri
npm/prettier-linter-helpers@1.0.0 None 0 9.58 kB bpscott
npm/read-pkg-up@7.0.1 None 0 6.73 kB sindresorhus
npm/read-pkg@5.2.0 filesystem 0 6.05 kB sindresorhus
npm/redux@5.0.1 None 0 290 kB phryneas
npm/regexp-tree@0.1.27 None 0 314 kB dmitrysoshnikov
npm/remark-mdx@3.1.0 None 0 14.7 kB wooorm
npm/resolve-cwd@3.0.0 None 0 4.98 kB sindresorhus
npm/rimraf@6.0.1 environment, filesystem 0 281 kB isaacs
npm/shell-quote@1.8.1 None 0 45 kB ljharb
npm/simple-git-hooks@2.12.1 filesystem 0 13.6 kB toplenboren
npm/string-argv@0.3.2 None 0 7.8 kB cellule
npm/strip-indent@3.0.0 None 0 3.31 kB sindresorhus
npm/text-table@0.2.0 None 0 11 kB substack
npm/ts-node@10.9.2 environment, filesystem, unsafe +1 1.3 MB blakeembrey
npm/typescript@5.8.2 None 0 22.9 MB typescript-bot
npm/uvu@0.5.6 None 0 48.3 kB lukeed
npm/v8-compile-cache-lib@3.0.1 environment, filesystem, unsafe 0 18.2 kB cspotcode
npm/vscode-json-languageservice@4.2.1 None 0 507 kB aeschli
npm/vscode-languageserver-textdocument@1.0.12 None 0 40.3 kB vscode-bot
npm/vscode-languageserver-types@3.17.5 None 0 377 kB vscode-bot
npm/vscode-nls@5.2.0 environment, filesystem 0 85.3 kB tylerl0706
npm/vscode-uri@3.1.0 None 0 204 kB microsoft1es
npm/yaml-eslint-parser@1.3.0 None 0 91.7 kB ota-meshi
npm/yarn-berry-deduplicate@6.1.1 None 0 65.1 kB churpeau
npm/yn@3.1.1 None 0 6.31 kB sindresorhus
npm/zod@3.24.2 None 0 699 kB colinhacks

🚮 Removed packages: npm/@eslint/config-helpers@0.1.0, npm/@eslint/eslintrc@3.3.0, npm/@eslint/js@9.22.0, npm/ajv@6.12.6, npm/chalk@4.1.2, npm/find-up@5.0.0, npm/flatted@3.3.3, npm/globals@14.0.0, npm/import-fresh@3.3.1, npm/js-yaml@4.1.0, npm/locate-path@6.0.0, npm/optionator@0.9.4, npm/p-limit@3.1.0, npm/p-locate@5.0.0, npm/resolve-from@4.0.0, npm/word-wrap@1.2.5

View full report↗︎

Copy link

codesandbox-ci bot commented Mar 29, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

pkg-pr-new bot commented Mar 29, 2025

Open in StackBlitz

npm i https://pkg.pr.new/eslint-plugin-import-x@270

commit: 0c34b69

Copy link

codecov bot commented Mar 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.18%. Comparing base (4587467) to head (5f29f8c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #270   +/-   ##
=======================================
  Coverage   96.18%   96.18%           
=======================================
  Files         106      106           
  Lines        5034     5037    +3     
  Branches     1756     1782   +26     
=======================================
+ Hits         4842     4845    +3     
+ Misses        191      186    -5     
- Partials        1        6    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JounQin JounQin enabled auto-merge (squash) March 29, 2025 20:58
@JounQin
Copy link
Member

JounQin commented Mar 29, 2025

@codecov-ai-reviewer review

Copy link

codecov-ai bot commented Mar 29, 2025

On it! We are reviewing the PR and will provide feedback shortly.

@JounQin
Copy link
Member

JounQin commented Mar 29, 2025

@coderabbitai review

Copy link

coderabbitai bot commented Mar 29, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@JounQin
Copy link
Member

JounQin commented Mar 29, 2025

@coderabbitai review

Copy link

coderabbitai bot commented Mar 29, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@JounQin
Copy link
Member

JounQin commented Mar 29, 2025

@codecov-ai-reviewer review

Copy link

codecov-ai bot commented Mar 29, 2025

On it! We are reviewing the PR and will provide feedback shortly.

@JounQin JounQin merged commit a2abfb6 into master Mar 29, 2025
67 checks passed
@JounQin JounQin deleted the renovate/all branch March 29, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant