Skip to content

const for max buffer size for stackalloc #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2022
Merged

const for max buffer size for stackalloc #73

merged 1 commit into from
May 15, 2022

Conversation

Sa1Gur
Copy link
Contributor

@Sa1Gur Sa1Gur commented May 15, 2022

Hi. I was interested in how does hashids calculated and spotted that constant for max buffer size allegeable for stackalloc could be introduced. I guess there is not reasons not to. May be I missed something.

@Sa1Gur
const for max buffer size for stackalloc
aca66ae 
introduced constant for max buffer size allegeable for stackalloc
@manigandham
Copy link
Collaborator

This is fine. 512 is a little big for stack allocation but you're right it's better as a const.

@manigandham manigandham merged commit eb3ca5b into ullmark:master May 15, 2022
@manigandham manigandham self-assigned this May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@manigandham manigandham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sa1Gur @manigandham