react-codemirror/merge/src/index.tsx

Lines 11 to 14 in 92c4abe

    
             /** 
        
              * Default is `false`. If true, the editor will be destroyed and re-rendered every time the editor is updated. 
        
              */ 
        
             destroyRerender?: boolean;

@denbalogh I'm trying to fix it by adding a destroyRerender prop to turn off re-rendering the component on every update.

react-codemirror/merge/src/Internal.tsx

Lines 78 to 84 in 92c4abe

    
           view.current?.a.dispatch({ 
        
             changes: { from: 0, to: originalDoc.length, insert: original.doc || '' }, 
        
             // effects: StateEffect.reconfigure.of([ 
        
             //   ...(originalExtension?.extension || []), 
        
             //   ...getDefaultExtensions({ ...originalExtension?.option, theme }), 
        
             // ]) 
        
           });

During the update, all extensions will be lost. If you add dispatch({ effects }), an @codemirror/merge internal error will be triggered.

So I thought of a compromise method and regenerated it after updating, which caused the onChange problem.

react-codemirror/merge/src/Internal.tsx

Lines 99 to 119 in 92c4abe

    
           if (destroyRerender) { 
        
             view.current?.destroy(); 
        
             view.current = new MergeView({ 
        
               a: { 
        
                 ...original, 
        
                 extensions: [ 
        
                   ...(originalExtension?.extension || []), 
        
                   ...getDefaultExtensions({ ...originalExtension?.option, theme }), 
        
                 ], 
        
               }, 
        
               b: { 
        
                 ...modified, 
        
                 extensions: [ 
        
                   ...(modifiedExtension?.extension || []), 
        
                   ...getDefaultExtensions({ ...modifiedExtension?.option, theme }), 
        
                 ], 
        
               }, 
        
               parent: editor.current!, 
        
               ...opts, 
        
             }); 
        
           }

	/**
	* Default is `false`. If true, the editor will be destroyed and re-rendered every time the editor is updated.
	*/
	destroyRerender?: boolean;

	view.current?.a.dispatch({
	changes: { from: 0, to: originalDoc.length, insert: original.doc \|\| '' },
	// effects: StateEffect.reconfigure.of([
	// ...(originalExtension?.extension \|\| []),
	// ...getDefaultExtensions({ ...originalExtension?.option, theme }),
	// ])
	});

	if (destroyRerender) {
	view.current?.destroy();
	view.current = new MergeView({
	a: {
	...original,
	extensions: [
	...(originalExtension?.extension \|\| []),
	...getDefaultExtensions({ ...originalExtension?.option, theme }),
	],
	},
	b: {
	...modified,
	extensions: [
	...(modifiedExtension?.extension \|\| []),
	...getDefaultExtensions({ ...modifiedExtension?.option, theme }),
	],
	},
	parent: editor.current!,
	...opts,
	});
	}

Uh oh!

CodeMirrorMerge gets unfocused on value change #566

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions