fix: Change iOS header import style to work with latest Expo #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ouabing react-native cli 编译不会出问题吧。 |
jaywcjlove
added a commit
that referenced
this pull request
Dec 18, 2021
|
我在 4.0.0-beta.1 上打上这个 commit 没有问题，但是 4.0.0 正式版会有这个错误： 应该是 #44 这个提交替换的 SDK 是不包含 UTDID 库的，可能需要没有使用阿里云别的 SDK 的使用者主动在 Podfile 里装一下 |
|
确认了下 Android 没这个编译问题 |
|
@ouabing 新的SDK 没有集成 |
|
我暂时没有时间仔细研究，目前看来 #44 这个 PR 应该就是为了避免和阿里云别的库的 UTDID 发生冲突，所以换成了不带 UTDID 的 Alipay SDK，见 https://help.aliyun.com/document_detail/39984.html 。 所以目前 react-native-alipay 4.0.0 里集成的是不带 UTDID 库的 SDK，但编译 alipay 还是需要 UTDID 库的，如果使用者没有用别的带有 UTDID 库的阿里云 SDK，则需要在 Podfile 里手动集成一下 不过我感觉这个是小众需求，应该没有太多人会用阿里云别的 SDK，所以我感觉应该给 react-native-alipay 同时发两个包比较好，一个是带 UTDID 的版本，一个不带。 |
Open
jaywcjlove
added a commit
that referenced
this pull request
Dec 18, 2021
jaywcjlove
added a commit
that referenced
this pull request
Dec 18, 2021
|
@ouabing 我更新了文档，但是发两个版本代码不好维护的样子。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expo 44.0 限制了 RN header 的 import 方式，不改成新的 import 方式会有编译问题，详见 expo/expo#15622 (comment)