Skip to content

JSStackTrace -> Ensure lineNumber exists before consuming (#24399) #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2019
Merged

JSStackTrace -> Ensure lineNumber exists before consuming (#24399) #3

merged 1 commit into from
Jul 29, 2019

Conversation

randy-miller
Copy link

No description provided.

@Salakar
JSStackTrace -> Ensure lineNumber exists before consuming (facebook#2…
7bccbc4 
…4399)

Summary:
Fixes facebook#24382

[ANDROID] [INTERNAL] - Fixed a `NoSuchKeyException` when parsing JS stack frames without line numbers.
Pull Request resolved: facebook#24399

Differential Revision: D14890746

Pulled By: cpojer

fbshipit-source-id: cea3653076484ad624084c370439f8a39c303083
edelventhal
edelventhal approved these changes Jul 29, 2019
View reviewed changes
Copy link

@edelventhal edelventhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@randy-miller randy-miller merged commit a630a3c into master Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@edelventhal edelventhal edelventhal approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@randy-miller @edelventhal @Salakar