Build changes for shared libs on Windows #372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfellis
approved these changes
Aug 7, 2020
|
|
||
| ## Building shared libraries | ||
|
|
||
| You can build H3 as a shared library (DLL), but the test suite does not support this configuration because the tests use functions internal to the DLL, and they are not exposed for testing. |
There was a problem hiding this comment.
I think you can drop everything after the comma.
| @@ -29,10 +29,19 @@ | |||
| #ifdef H3_ALLOC_PREFIX | |||
| #define H3_MEMORY(name) TJOIN(H3_ALLOC_PREFIX, name) | |||
|
|
|||
| #ifdef __cplusplus | |||
| extern "C" { | |||
There was a problem hiding this comment.
When is Microsoft going to give up this stupid fight and compile normal C?
| @@ -152,46 +163,47 @@ typedef struct { | |||
| */ | |||
| /** @brief find the H3 index of the resolution res cell containing the lat/lng | |||
| */ | |||
| H3Index H3_EXPORT(geoToH3)(const GeoCoord *g, int res); | |||
| DECLSPEC H3Index H3_EXPORT(geoToH3)(const GeoCoord *g, int res); | |||
There was a problem hiding this comment.
Not going to block on this, but I wonder if it would have been possible to modify the H3_EXPORT instead to tackle this, eg: H3_EXPORT(H3Index, geoToH3)(const GeoCoord *g, int res); and macro args may or may not include the DECLSPEC thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#366
This PR is still a draft. It changes how DLLs are built on Windows.
TODO: