feat(fuzzer): Add gridRing test to fuzzerGridDisk #1015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacbrodsky
reviewed
Jun 5, 2025
src/apps/fuzzers/fuzzerGridDisk.c
Outdated
| @@ -56,6 +56,11 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) { | |||
| H3_EXPORT(gridDiskUnsafe)(args->index, args->k, results); | |||
| } | |||
| free(results); | |||
| results = calloc(sizeof(H3Index), sz); | |||
| if (results != NULL) { | |||
| H3_EXPORT(gridRing)(args->index, args->k, results); // Test the safe version | |||
There was a problem hiding this comment.
Suggested change
| H3_EXPORT(gridRing)(args->index, args->k, results); // Test the safe version | |
| H3_EXPORT(gridRing)(args->index, args->k, results); // Test the safe version |
small formatting issue that will get flagged in CI
justinhwang
reviewed
Jun 5, 2025
src/apps/fuzzers/fuzzerGridDisk.c
Outdated
Comment on lines
59
to
63
| results = calloc(sizeof(H3Index), sz); | ||
| if (results != NULL) { | ||
| H3_EXPORT(gridRing)(args->index, args->k, results); // Test the safe version | ||
| } | ||
| free(results); |
There was a problem hiding this comment.
nit: maybe move the whole block to after gridRingUnsafe
|
move to below gridRingUnsafe and formating corrected! |
isaacbrodsky
reviewed
Jun 5, 2025
src/apps/fuzzers/fuzzerGridDisk.c
Outdated
| @@ -56,6 +56,7 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) { | |||
| H3_EXPORT(gridDiskUnsafe)(args->index, args->k, results); | |||
| } | |||
| free(results); | |||
| results = calloc(sizeof(H3Index), sz); | |||
There was a problem hiding this comment.
this line should also move down or there will be a use-after-free
|
fixed, sorry was working on issue #984 did this change a bit too quickly |
dfellis
approved these changes
Jun 6, 2025
isaacbrodsky
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds gridRing testing to fuzzerGridDisk.c to improve test coverage as requested in #1011 and as I tried but ran into merge issues with in #1012.