Skip to content

Remove noisy log #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 5, 2025
Merged

Remove noisy log #421

merged 4 commits into from
Aug 5, 2025

Conversation

hweawer
Copy link
Collaborator

@hweawer hweawer commented Aug 4, 2025

Removing noisy logs from nginx

Copy link
Collaborator

@Anton-Kalpakchiev Anton-Kalpakchiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we test this? Can you add a test plan to the diff description?

@@ -231,7 +231,10 @@ func Run(config Config, params map[string]interface{}, opts ...Option) error {
}

func populateTemplate(tmpl string, args map[string]interface{}) ([]byte, error) {
t, err := template.New("nginx").Parse(tmpl)
funcMap := template.FuncMap{
"healthEndpoint": generateHealthEndpoint,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, feel free to land as is: I believe nginx uses kebab-case, not camelCase

@hweawer
Copy link
Collaborator Author

hweawer commented Aug 5, 2025

Did we test this? Can you add a test plan to the diff description?

Tested in devzone

@hweawer hweawer merged commit 4294f57 into master Aug 5, 2025
5 of 7 checks passed
@hweawer hweawer deleted the remove-noisy-log branch August 5, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants