-
Notifications
You must be signed in to change notification settings - Fork 450
Fix ci forks #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ci forks #416
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick question, maybe we can add it in the PR description also.
docker/build-index/Dockerfile
Outdated
|
||
RUN apt-get update && apt-get install -y curl nginx | ||
# Fix repository configuration for Debian 12 (bookworm) with multiple mirrors and better retry logic | ||
RUN rm -f /etc/apt/sources.list.d/debian.sources && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of adding these before installing the dependencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These configs:
RUN echo 'Acquire::Check-Valid-Until "false";' > /etc/apt/apt.conf.d/99no-check-valid-until && \
echo 'Acquire::AllowInsecureRepositories "true";' >> /etc/apt/apt.conf.d/99no-check-valid-until && \
echo 'Acquire::Retries "10";' >> /etc/apt/apt.conf.d/99no-check-valid-until && \
echo 'Acquire::http::Timeout "60";' >> /etc/apt/apt.conf.d/99no-check-valid-until
Are making debian packages downloads more reliable, I had issues with reliability of debian repos. I removed lines regarding /etc/apt/sources.list.d/debian.sources was experimenting with how to fix reliability issues, seems it can work without rewriting repositories, but just with a lot of retries and longer timeouts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation @hweawer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Fix CI for forks