Skip to content

Fix ci forks #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 30, 2025
Merged

Fix ci forks #416

merged 5 commits into from
Jul 30, 2025

Conversation

hweawer
Copy link
Collaborator

@hweawer hweawer commented Jul 29, 2025

Fix CI for forks

@hweawer hweawer self-assigned this Jul 29, 2025
@hweawer hweawer requested a review from sambhav-jain-16 July 29, 2025 14:41
Copy link
Collaborator

@sambhav-jain-16 sambhav-jain-16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question, maybe we can add it in the PR description also.


RUN apt-get update && apt-get install -y curl nginx
# Fix repository configuration for Debian 12 (bookworm) with multiple mirrors and better retry logic
RUN rm -f /etc/apt/sources.list.d/debian.sources && \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of adding these before installing the dependencies?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These configs:

RUN echo 'Acquire::Check-Valid-Until "false";' > /etc/apt/apt.conf.d/99no-check-valid-until && \
    echo 'Acquire::AllowInsecureRepositories "true";' >> /etc/apt/apt.conf.d/99no-check-valid-until && \
    echo 'Acquire::Retries "10";' >> /etc/apt/apt.conf.d/99no-check-valid-until && \
    echo 'Acquire::http::Timeout "60";' >> /etc/apt/apt.conf.d/99no-check-valid-until

Are making debian packages downloads more reliable, I had issues with reliability of debian repos. I removed lines regarding /etc/apt/sources.list.d/debian.sources was experimenting with how to fix reliability issues, seems it can work without rewriting repositories, but just with a lot of retries and longer timeouts.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation @hweawer

@hweawer hweawer requested a review from sambhav-jain-16 July 30, 2025 10:57
Copy link
Collaborator

@sambhav-jain-16 sambhav-jain-16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@hweawer hweawer merged commit 5b389a6 into master Jul 30, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants