Skip to content

Fix Mac setup issues and add comprehensive codelab #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jul 30, 2025

Conversation

ArnabBir
Copy link
Contributor

  • Fixed binary permission issues in all Dockerfiles by adding chmod +x
  • Fixed TLS configuration mismatches in development configs
  • Added comprehensive Mac setup codelab with step-by-step instructions
  • All changes enable successful Kraken P2P testing on Mac with Docker Desktop

Fixes:

  • Binary execution permission errors
  • TLS certificate errors during container communication
  • Provides complete troubleshooting guide for new users

- Fixed binary permission issues in all Dockerfiles by adding chmod +x
- Fixed TLS configuration mismatches in development configs
- Added comprehensive Mac setup codelab with step-by-step instructions
- All changes enable successful Kraken P2P testing on Mac with Docker Desktop

Fixes:
- Binary execution permission errors
- TLS certificate errors during container communication
- Provides complete troubleshooting guide for new users
@CLAassistant
Copy link

CLAassistant commented Jul 18, 2025

CLA assistant check
All committers have signed the CLA.

@gkeesh7
Copy link
Collaborator

gkeesh7 commented Jul 18, 2025

Hi @ArnabBir,

Thanks for your PR to Kraken. I’ll review your changes shortly.

In the meantime, please make sure to sign the CLA (Contributor License Agreement) for the project.

@gkeesh7 gkeesh7 requested review from gkeesh7 and hweawer July 18, 2025 11:51
ArnabBir added 8 commits July 18, 2025 18:02
- Updated KRAKEN_SETUP_CODELAB.md with comprehensive scaling section
- Added scripts for agents three, four, and five
- Added helper scripts for starting/stopping additional agents
- Documented manual agent creation process
- Added port management and P2P testing guidance
@gkeesh7 gkeesh7 requested a review from sambhav-jain-16 July 24, 2025 10:09
@gkeesh7 gkeesh7 added bug Something isn't working Documentation labels Jul 24, 2025
@ArnabBir ArnabBir requested a review from sambhav-jain-16 July 25, 2025 10:55
Copy link
Collaborator

@sambhav-jain-16 sambhav-jain-16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArnabBir for patiently resolving the comments. Really appreciated !

I have 2 very minor nits. Apart from it LGTM !

I'll wait for @gkeesh7 to also look at this PR. Thanks !

ArnabBir and others added 2 commits July 25, 2025 18:32
Patched the suggestion. Thanks!

Co-authored-by: Sambhav Jain <67923444+sambhav-jain-16@users.noreply.github.com>
@ArnabBir ArnabBir requested a review from sambhav-jain-16 July 25, 2025 13:04
@ArnabBir ArnabBir requested a review from sambhav-jain-16 July 30, 2025 08:09
@sambhav-jain-16
Copy link
Collaborator

Thanks @ArnabBir for the fixes. One last request, can you rebase your PR to the latest master branch?
There are some changes that adds a CI job so we will be able to detect breaking changes (if any) for this PR. TIA

@ArnabBir
Copy link
Contributor Author

@sambhav-jain-16 Rebased with the remote master branch.

Copy link
Collaborator

@sambhav-jain-16 sambhav-jain-16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArnabBir for resolving all comments.
LGTM !

@ArnabBir
Copy link
Contributor Author

Thanks @sambhav-jain-16 for the approval! Requesting merge to the maintainers when ready.

@sambhav-jain-16 sambhav-jain-16 merged commit bb9523c into uber:master Jul 30, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants