-
Notifications
You must be signed in to change notification settings - Fork 450
Fix Mac setup issues and add comprehensive codelab #414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Fixed binary permission issues in all Dockerfiles by adding chmod +x - Fixed TLS configuration mismatches in development configs - Added comprehensive Mac setup codelab with step-by-step instructions - All changes enable successful Kraken P2P testing on Mac with Docker Desktop Fixes: - Binary execution permission errors - TLS certificate errors during container communication - Provides complete troubleshooting guide for new users
Hi @ArnabBir, Thanks for your PR to Kraken. I’ll review your changes shortly. In the meantime, please make sure to sign the CLA (Contributor License Agreement) for the project. |
- Updated KRAKEN_SETUP_CODELAB.md with comprehensive scaling section - Added scripts for agents three, four, and five - Added helper scripts for starting/stopping additional agents - Documented manual agent creation process - Added port management and P2P testing guidance
This reverts commit a8ab3dc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patched the suggestion. Thanks! Co-authored-by: Sambhav Jain <67923444+sambhav-jain-16@users.noreply.github.com>
Thanks @ArnabBir for the fixes. One last request, can you rebase your PR to the latest master branch? |
…setup-fixes rebased with master
@sambhav-jain-16 Rebased with the remote master branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ArnabBir for resolving all comments.
LGTM !
Thanks @sambhav-jain-16 for the approval! Requesting merge to the maintainers when ready. |
Fixes: