Skip to content

Prefetch endpoint proxy #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Apr 14, 2025
Merged

Prefetch endpoint proxy #402

merged 30 commits into from
Apr 14, 2025

Conversation

hweawer
Copy link
Collaborator

@hweawer hweawer commented Mar 21, 2025

What

Adding prefetching endpoint into kraken-proxy.

Tested in devzone and in dca94

@hweawer hweawer self-assigned this Mar 21, 2025
Copy link
Collaborator

@gkeesh7 gkeesh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments

@@ -159,15 +152,10 @@ func Run(flags *Flags, opts ...Option) {

transferer := transfer.NewReadWriteTransferer(stats, tagClient, originCluster, cas)

// Open preheat function only if server-port was defined.
if flags.ServerPort != 0 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why you are removing the Serverport check ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am running the server for prefetching on the same port as other proxy servers.

@hweawer hweawer requested a review from gkeesh7 April 10, 2025 11:06
@hweawer hweawer requested a review from gkeesh7 April 10, 2025 12:11
@hweawer hweawer requested a review from gkeesh7 April 11, 2025 12:07
Copy link
Collaborator

@gkeesh7 gkeesh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments LGTM

@hweawer hweawer merged commit 19dfd2a into master Apr 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants