-
Notifications
You must be signed in to change notification settings - Fork 449
Prefetch endpoint proxy #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the comments
@@ -159,15 +152,10 @@ func Run(flags *Flags, opts ...Option) { | |||
|
|||
transferer := transfer.NewReadWriteTransferer(stats, tagClient, originCluster, cas) | |||
|
|||
// Open preheat function only if server-port was defined. | |||
if flags.ServerPort != 0 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why you are removing the Serverport check ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am running the server for prefetching on the same port as other proxy servers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the comments LGTM
What
Adding prefetching endpoint into kraken-proxy.
Tested in devzone and in dca94