Skip to content

Support Multi-Arch by Supporting Manifest List #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2022
Merged

Support Multi-Arch by Supporting Manifest List #326

merged 1 commit into from
Sep 22, 2022

Conversation

xinlongz1
Copy link
Collaborator

Summary:
Adds Multi-Arch support by supporting manifest list.

Testing
Bring up dev cluster locally.

  1. Build two images with different arch.
REPOSITORY              TAG           IMAGE ID       CREATED      SIZE
testing/testing-build   arm64v8-1.0   cb18cbc8100d   6 days ago   74.5MB
testing/testing-build   amd64-1.0     840a89ece7a1   6 days ago   80.9MB
  1. Push them.
xinlongz@xinlongz-C02ZX4VAMD6M multi-arch % docker push localhost:15000/testing/testing-build:arm64v8-1.0
The push refers to repository [localhost:15000/testing/testing-build]
948260395c24: Pushed 
377e88cd1334: Pushed 
arm64v8-1.0: digest: sha256:0e19e811ecf370db27644346585b89152af8c647addf9e1b302e0864f0e07b93 size: 740
xinlongz@xinlongz-C02ZX4VAMD6M multi-arch % docker push localhost:15000/testing/testing-build:amd64-1.0
The push refers to repository [localhost:15000/testing/testing-build]
ebbade774b0d: Pushed 
56a5c11640c8: Pushed 
amd64-1.0: digest: sha256:d35e2f18bd6f155884c9f91ff85120480e9aed203b7285911c922d6f900c5a15 size: 740
  1. Create the manifest list.
docker manifest create --insecure localhost:15000/testing/testing-build:1.0 localhost:15000/testing/testing-build:arm64v8-1.0 localhost:15000/testing/testing-build:amd64-1.0
Created manifest list localhost:15000/testing/testing-build:1.0
  1. Push the manifest list.
docker manifest push --insecure localhost:15000/testing/testing-build:1.0
sha256:6f4eb514d2427f874bc2176111a794a1fcaf49bbdd2d87ac95075799b5bf281b
  1. docker pull with the manifest list tag.
docker pull localhost:16000/testing/testing-build:1.0
1.0: Pulling from testing/testing-build
Digest: sha256:6f4eb514d2427f874bc2176111a794a1fcaf49bbdd2d87ac95075799b5bf281b
Status: Downloaded newer image for localhost:16000/testing/testing-build:1.0
localhost:16000/testing/testing-build:1.0
  1. The pulled image localhost:16000/testing/testing-build:1.0 has the same image ID as the images with amd64-1.0 tag. This is because the platform of the local machine is amd64.
testing/testing-build                            arm64v8-1.0   cb18cbc8100d   6 days ago      74.5MB
localhost:15000/testing/testing-build            arm64v8-1.0   cb18cbc8100d   6 days ago      74.5MB
testing/testing-build                            amd64-1.0     840a89ece7a1   6 days ago      80.9MB
localhost:15000/testing/testing-build            amd64-1.0     840a89ece7a1   6 days ago      80.9MB
localhost:16000/testing/testing-build            1.0           840a89ece7a1   6 days ago      80.9MB

@CLAassistant
Copy link

CLAassistant commented Aug 30, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

evelynl94
evelynl94 reviewed Sep 19, 2022
View reviewed changes
evelynl94
evelynl94 reviewed Sep 19, 2022
View reviewed changes
@evelynl94 evelynl94 merged commit 8d52a0f into uber:master Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evelynl94 evelynl94 evelynl94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xinlongz1 @CLAassistant @evelynl94