Skip to content

Remove persistedretry queue counter #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Remove persistedretry queue counter #316

merged 1 commit into from
Jan 3, 2022

Conversation

codygibb
Copy link
Contributor

@codygibb codygibb commented Jan 3, 2022

Counters cannot be decremented -- in fact, decrementing a prometheus counter
will cause a panic. If we want to represent queue size, we need to use a gauge, but
this would require quite a bit of work to implement correctly (regretfully our choice to
use channels makes this much more difficult than it should). Let's just get rid of the
counters entirely since this is totally broken anyway.

@codygibb codygibb requested a review from evelynl94 January 3, 2022 23:35
@codygibb codygibb merged commit d88f5ca into master Jan 3, 2022
@codygibb codygibb deleted the codyg/fix-panic branch January 3, 2022 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants