Remove persistedretry queue counter #316
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Counters cannot be decremented -- in fact, decrementing a prometheus counter
will cause a panic. If we want to represent queue size, we need to use a gauge, but
this would require quite a bit of work to implement correctly (regretfully our choice to
use channels makes this much more difficult than it should). Let's just get rid of the
counters entirely since this is totally broken anyway.