Skip to content

Allow overriding nginx log paths #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Allow overriding nginx log paths #279

merged 1 commit into from
Oct 7, 2020

Conversation

codygibb
Copy link
Contributor

@codygibb codygibb commented Oct 7, 2020

Lets us optionally emit nginx logs to specific files instead of just a directory.

@codygibb codygibb requested a review from evelynl94 October 7, 2020 18:16
@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

Merging #279 into master will decrease coverage by 1.63%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #279      +/-   ##
==========================================
- Coverage   66.44%   64.80%   -1.64%     
==========================================
  Files         186      186              
  Lines        9226     7822    -1404     
==========================================
- Hits         6130     5069    -1061     
+ Misses       2337     1999     -338     
+ Partials      759      754       -5     
Impacted Files Coverage Δ
lib/backend/config.go 16.66% <0.00%> (-20.84%) ⬇️
lib/healthcheck/config.go 16.66% <0.00%> (-16.67%) ⬇️
lib/backend/throttle.go 29.41% <0.00%> (-14.59%) ⬇️
core/digester.go 53.84% <0.00%> (-12.83%) ⬇️
lib/backend/client.go 60.00% <0.00%> (-11.43%) ⬇️
lib/backend/fixtures.go 50.00% <0.00%> (-10.00%) ⬇️
tracker/peerhandoutpolicy/fixtures.go 50.00% <0.00%> (-10.00%) ⬇️
tracker/peerhandoutpolicy/completeness_policy.go 66.66% <0.00%> (-8.34%) ⬇️
build-index/tagtype/docker_resolver.go 42.85% <0.00%> (-7.15%) ⬇️
lib/store/base/file_readwriter.go 53.84% <0.00%> (-7.03%) ⬇️
... and 175 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a67e219...c810c40. Read the comment docs.

@codygibb codygibb merged commit 8dc6d59 into master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants