Always delete upload file after MoveUploadFileToCache #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #274 +/- ##
==========================================
+ Coverage 66.34% 66.47% +0.12%
==========================================
Files 186 186
Lines 9224 9220 -4
==========================================
+ Hits 6120 6129 +9
+ Misses 2340 2333 -7
+ Partials 764 758 -6
Continue to review full report at Codecov.
|
codygibb
approved these changes
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An upload files is a temp file with a random uuid name. The uuid name is discarded after the file is committed to the file store and should not be reused. When MoveUploadFileToCache fails, it indicates that there is a problem reading/streaming the file or the content is corrupted. We should delete the upload file regardless to avoid failed uploads accumulating on disk.