make nginx path configurable #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
==========================================
+ Coverage 66.43% 66.44% +0.01%
==========================================
Files 186 186
Lines 9226 9226
==========================================
+ Hits 6129 6130 +1
+ Misses 2338 2337 -1
Partials 759 759
Continue to review full report at Codecov.
|
evelynl94
reviewed
Sep 17, 2020
nginx/nginx.go
Outdated
| @@ -111,6 +113,13 @@ func (c *Config) Build(params map[string]interface{}) ([]byte, error) { | |||
| return src, nil | |||
| } | |||
|
|
|||
| func (c *Config) getBinary() string { | |||
There was a problem hiding this comment.
the convention is this repo is to have a function called applyDefaults(). You can also put it in the beginning of Run().
5aae6b5 to
38d48cc
Compare
evelynl94
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a modification for test purpose. The soft link in
/usr/sbinon mac OS does not work