Skip to content

downgrading protobouf to 1.3.3 for compatibility reasons #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

SQUIDwarrior
Copy link
Contributor

@SQUIDwarrior SQUIDwarrior commented May 15, 2020

Protobuf 1.4.0 has compatibility problems certain Bazel rules, so this downgrades it to 1.3.3.

@CLAassistant
Copy link

CLAassistant commented May 15, 2020

CLA assistant check
All committers have signed the CLA.

@SQUIDwarrior SQUIDwarrior changed the title downgrading protobouf to 1.3.2 for compatibility reasons downgrading protobouf to 1.3.3 for compatibility reasons May 15, 2020
@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #258 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #258      +/-   ##
==========================================
+ Coverage   66.10%   66.11%   +0.01%     
==========================================
  Files         184      184              
  Lines        9098     9098              
==========================================
+ Hits         6014     6015       +1     
+ Misses       2322     2321       -1     
  Partials      762      762              
Impacted Files Coverage Δ
utils/dedup/interval_trap.go 90.00% <0.00%> (-10.00%) ⬇️
lib/torrent/scheduler/events.go 72.59% <0.00%> (+1.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ebc167...ccfe1ad. Read the comment docs.

@yiranwang52 yiranwang52 merged commit d8d5afb into uber:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants