Skip to content

Makefile modification #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 6, 2020
Merged

Makefile modification #249

merged 3 commits into from
May 6, 2020

Conversation

zerosnake0
Copy link
Contributor

  1. Add GOPROXY env for slow go get operation
  2. Golang version is configurable
  3. Remove duplicate docker tag target

@CLAassistant
Copy link

CLAassistant commented May 6, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #249 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
- Coverage   66.07%   66.05%   -0.03%     
==========================================
  Files         184      184              
  Lines        9105     9105              
==========================================
- Hits         6016     6014       -2     
- Misses       2325     2326       +1     
- Partials      764      765       +1
Impacted Files Coverage Δ
utils/dedup/interval_trap.go 90.00% <0.00%> (-10.00%) ⬇️
lib/torrent/scheduler/events.go 72.59% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78baa5e...b12b6b6. Read the comment docs.

@codecov
Copy link

codecov bot commented May 6, 2020 •
edited
Loading

Codecov Report

Merging #249 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
- Coverage   66.07%   66.00%   -0.07%     
==========================================
  Files         184      184              
  Lines        9105     9105              
==========================================
- Hits         6016     6010       -6     
- Misses       2325     2329       +4     
- Partials      764      766       +2
Impacted Files Coverage Δ
utils/dedup/interval_trap.go 90.00% <0.00%> (-10.00%) ⬇️
core/peer_info.go 83.33% <0.00%> (-5.56%) ⬇️
lib/torrent/scheduler/events.go 71.15% <0.00%> (-1.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78baa5e...bab6b2a. Read the comment docs.

yiranwang52
yiranwang52 reviewed May 6, 2020
View reviewed changes
Makefile
@@ -5,6 +5,9 @@ GO = go
BUILD_FLAGS = -gcflags '-N -l'
BUILD_QUIET ?= -q

GOLANG_IMAGE ?= golang:1.14
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

golang image is configured in multiple places - like in the dockerfiles used in make images
Do you plan to change all the places?

Copy link
Contributor Author

@zerosnake0 zerosnake0 May 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look at the dockerfiles used in make images, they are based on debian:10 and all binaries are copied from the prebuild LINUX_BINS, which is already affected by the modification. I did not find any other place using a versioned Go yet.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I take it back. This is good then.

@yiranwang52 yiranwang52 merged commit d7abf7d into uber:master May 6, 2020
@zerosnake0 zerosnake0 deleted the go_compile_option branch May 6, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiranwang52 yiranwang52 yiranwang52 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zerosnake0 @CLAassistant @yiranwang52