Add skipped announces back to queue #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @mmpei |
evelynl94
approved these changes
May 31, 2019
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #167 +/- ##
==========================================
+ Coverage 67.28% 67.40% +0.12%
==========================================
Files 179 179
Lines 8743 8754 +11
==========================================
+ Hits 5883 5901 +18
+ Misses 2116 2111 -5
+ Partials 744 742 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a torrent is at capacity, we skip announcing that torrent. However, we were not re-adding
that torrent back to the announce queue, so it wouldn't announce again until it was completed.
In practice, if a torrent is at capacity it will very likely be completed, so this bug went by
unnoticed for a long time.
Now, we skip all torrents that are at capacity until we reach a torrent we want to announce.
Then we re-enqueue all the skipped torrents.