Skip to content

Add ls command to tvm #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 2, 2019
Merged

Add ls command to tvm #37

merged 3 commits into from
Oct 2, 2019

Conversation

dansimau
Copy link
Contributor

@dansimau dansimau commented Aug 1, 2019 •
edited
Loading

This allows you to list the locally-downloaded versions of Terraform in
the tvm repo/cache, e.g.:

$ tvm ls
0.12.5
0.12.0
0.11.11
0.11.9
0.11.7
0.11.5 (current, installed at: /usr/local/bin/terraform)
0.10.8
0.9.11
0.8.8
0.7.13
0.7.11
0.7.7
0.7.0
0.6.0

There are no tests for tvm yet. I think we can add this in a later diff. To
support testing we need to refactor the CLI to match the same pattern as the
astro CLI.

@dansimau
Add ls command to tvm
9fc4e9b 
This allows you to list the locally-downloaded versions of Terraform in
the tvm repo/cache.
@dansimau dansimau requested a review from btromanova August 1, 2019 09:05
@dansimau dansimau self-assigned this Aug 1, 2019
btromanova
btromanova reviewed Oct 2, 2019
View reviewed changes
astro/tvm/cli/tvm/cmd/list.go Outdated
@@ -0,0 +1,95 @@
/*
* Copyright (c) 2018 Uber Technologies, Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/2018/2019/

astro/tvm/versionrepo.go Outdated
return nil, err
}

f.Close()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not defer f.Close() right after you opened it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brain fart

@btromanova btromanova merged commit c972a31 into master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@btromanova btromanova btromanova approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@dansimau dansimau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dansimau @btromanova