Skip to content

Include tvm into the astro tarball #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 14, 2020
Merged

Include tvm into the astro tarball #59

merged 5 commits into from
Jan 14, 2020

Conversation

btromanova
Copy link
Contributor

@btromanova btromanova commented Jan 14, 2020 •
edited
Loading

This addresses #58.

Changes:

  • archive -> archives as the latest version of goreleaser only recognize the plural one
  • add tvm to the goreleaser builds (also add build id otherwise it defaults to project_name)
  • add note to readme to say that tvm is included

Tested it by pushing tag and running

docker run --rm --privileged -v $PWD:/go/src/github.com/uber/astro -v /var/run/docker.sock:/var/run/docker.sock -w /go/src/github.com/uber/astro -e GITHUB_TOKEN=<> goreleaser/goreleaser  release --rm-dist

I've seen that goreleaser was successful and the tarballs with both astro and tvm were published to github.

@btromanova btromanova changed the base branch from master to tr/remove-github-actions January 14, 2020 15:19
@btromanova btromanova requested a review from dansimau January 14, 2020 15:20
@dansimau
Copy link
Contributor

Looks good. Is there a way to include the actual README.md in the tarball, instead of just a link to the Github page?

@btromanova
Copy link
Contributor Author

I've just checked and verified that the actual README is already included. Was it a link to github at some point?

@btromanova btromanova merged commit 2e0820a into tr/remove-github-actions Jan 14, 2020
btromanova added a commit that referenced this pull request Jan 14, 2020
@btromanova
Revert "Include tvm into the astro tarball (#59)"
a3756f0 
This reverts commit 2e0820a.
@btromanova btromanova mentioned this pull request Jan 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dansimau dansimau dansimau approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@btromanova @dansimau