Fix bug in initialization of allowed values #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b47bed6 to
9786ac8
Compare
DragonZ
requested changes
Aug 14, 2019
DragonZ
approved these changes
Aug 21, 2019
83ebb48 to
37cf7c3
Compare
b97d7a5 to
90fa618
Compare
90fa618 to
3144964
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #42.
The bug was in copying reference of array containing values from config into array containing all allowed values. The latter was then modified (by adding values and sorting), which caused items in the values array to change.
This PR replaces copy by reference to creation of new array and coping values and modifies test to go through the previously failing scenario.