Get plan output with terraform 0.12 #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DragonZ
requested changes
Aug 13, 2019
DragonZ
approved these changes
Aug 14, 2019
dansimau
approved these changes
Sep 19, 2019
astro/tests/integration_test.go
Outdated
| assert.Contains(t, result.Stderr.String(), "Error parsing") | ||
| errorMessage := "Error parsing" | ||
| if stringVersionMatches(version, ">=0.12") { | ||
| errorMessage = "Argument or block definition required" |
There was a problem hiding this comment.
This string has a weird character at the end (character code 27). I'd probably just remove it.
83ebb48 to
37cf7c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #38 and adds 0.12.6 to the list of versions we test against.
Context:
terraform showis broken since 0.12 (see hashicorp/terraform#21446), so I'm using regex on top ofterraform planto produce the plan output.I've fixed tests to support changes in output in 0.12.