Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: uber-go/ratelimit
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.3.0
Choose a base ref
...
head repository: uber-go/ratelimit
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.3.1
Choose a head ref
  • 8 commits
  • 10 files changed
  • 1 contributor

Commits on Jul 9, 2023

  1. Back to development

    rabbbit committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    2fd8c93 View commit details
    Browse the repository at this point in the history
  2. Minimize permissions on CI workflows (#110)

    They only need read permissions.
    rabbbit authored Jul 9, 2023
    Configuration menu
    Copy the full SHA
    021eef1 View commit details
    Browse the repository at this point in the history
  3. Use latest version of github actions. (#112)

    I do wonder whether #111 is failing due to the caching we might have (?)
    
    Based on https://github.com/uber-go/zap/blob/master/.github/workflows/go.yml
    rabbbit authored Jul 9, 2023
    Configuration menu
    Copy the full SHA
    25bdf05 View commit details
    Browse the repository at this point in the history
  4. Update tools dependencies to latest versions (#113)

    * Update `tools`  versions
    
    Trying to get #111 to run.
    
    Not upgrading staticcheck above 0.3.3 because it requires Go1.19 which we cannot upgrade to yet (#111)
    rabbbit authored Jul 9, 2023
    Configuration menu
    Copy the full SHA
    a0d3e65 View commit details
    Browse the repository at this point in the history
  5. Run tests on the latest 2 go versions, update go directive in go.mod (#…

    …114)
    
    * Run tests on the latest 2 go versions, update go directive in go.mod
    
    We support the latest two versions; we should be testing them.
    
    Go directive shouldn't change much, I'm updating it to be in sync.
    We're still pre Go 1.21, so this should not affect the users.
    
    Need to update statichceck in the same PR:
    - without it, it cannot recognize the new go version
    - at the same time, staticcheck 0.3.3+ requires Go1.19
    rabbbit authored Jul 9, 2023
    Configuration menu
    Copy the full SHA
    76fa6b7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    60908a3 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Fix an issue with maxSlack boundary updates. (#124)

    Fixes #119
    The solution is a copy from #120, but follows the testing framework
    that we have - I did not want us to have a real `Sleep` in tests.
    
    I'm not exactly thrilled by the testing setup (especially the
    milliseconds) or the clock itself, but I'm not willing to totally give
    up on it like #120 proposes.
    I also wanted ALL implementations of the ratelimiter to be tested,
    not just the currently selected.
    
    Might follow up with some testing cleanups and/or clock migration.
    rabbbit authored Mar 4, 2024
    Configuration menu
    Copy the full SHA
    9364ca3 View commit details
    Browse the repository at this point in the history
  2. Preparing release v0.3.1 (#125)

    Includes a prety serious slack bug, so IMO we should push a new
    minor version.
    rabbbit authored Mar 4, 2024
    Configuration menu
    Copy the full SHA
    61eed72 View commit details
    Browse the repository at this point in the history
Loading