Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: uber-go/fx
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.19.0
Choose a base ref
...
head repository: uber-go/fx
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.19.1
Choose a head ref
  • 4 commits
  • 8 files changed
  • 1 contributor

Commits on Jan 4, 2023

  1. Configuration menu
    Copy the full SHA
    213eb86 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2023

  1. Fix Start ctx expiration making app unstoppable (#1017)

    This fixes #1015.
    
    When Start() is called, it passes StartTimeout to the relayer goroutine,
    which is monitoring the Stop signal, as well as the OS signal handler.
    
    It then exits the goroutine if the start context expires, which would
    naturally happen if the user uses the default setting (15s timeout) or
    any finite amount of timeout value.
    
    This causes the app to then be not responsive to any OS signals such as
    SIGTERM or SIGINT.
    
    This was a regression introduced in 1.19 release via #989 .
    
    To fix this, this commit simply removes the relayer goroutine from
    selecting on the start context being completed.
    
    Verified that all tests are still passing without any goroutine leak,
    except one test that was triggering a panic to test the panic handler.
    
    To prevent that one test from opting out every single test into
    goleak.VerifyNone(t) in every sub test, I pulled out that panic test
    into a separate test package so that we can continue to use
    goleak.VerifyNone() method in app_test.
    sywhang authored Jan 9, 2023
    Configuration menu
    Copy the full SHA
    f0d73c6 View commit details
    Browse the repository at this point in the history
  2. Allow stopping app after Stop() has been called (#1019)

    Starting from 1.19, calling Stop() when an app has been stopped returns
    an error.
    
    This actually is an unexpected change for many users who have been using
    fxtest for testing their apps. Specifically, if they have a server that
    errors out when tests are written, these will often trigger Stop() to be
    called many times..
    sywhang authored Jan 9, 2023
    Configuration menu
    Copy the full SHA
    91e752c View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2023

  1. Configuration menu
    Copy the full SHA
    d9d9838 View commit details
    Browse the repository at this point in the history
Loading