Mark VerifyNone as a test Helper #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
abhinav
reviewed
Aug 17, 2022
There was a problem hiding this comment.
Thanks for the contribution, @tallclair!
This is a reasonable request, but we'd prefer to do this in a backwards compatible way.
I've left a suggestion on how we can do that.
Separately, can you please also sign the CLA? We cannot land the change without that.
|
I'm waiting on approval from my org to sign the CLA, sorry I may have jumped the gun on this. |
|
Sorry for the delay. CLA is signed, and comments have been addressed. |
abhinav
approved these changes
Aug 30, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark
VerifyNone(...)as a testHelperfunction, so that it reports the error at the call site, rather thanleaks.go:78:.From the go docs:
This is useful for tests that verify go routines at multiple points, so failures can be more easily distinguished.