Remove no longer needed tracestack_new.go file #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinav
approved these changes
Jun 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #123 +/- ##
=======================================
Coverage 99.14% 99.14%
=======================================
Files 6 5 -1
Lines 234 234
=======================================
Hits 232 232
Misses 1 1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
|
The lint error seems to be because of golangci-lint upgrade. |
sywhang
approved these changes
Jun 5, 2024
@sywhang I think to fix that, we may need to change the golangci config—or just fix the lint issue. Up to you. |
|
yeah, let me fix that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR moves
isTraceStackfrom thetracestack_new.gotooptions.go. The filetracestack_new.gobecame unnecessary after #79.