Skip to content

Conversation

aaronweeden
Copy link
Contributor

@aaronweeden aaronweeden commented Jan 30, 2024

Description

Builds with the supremm module are currently failing on the composer install step with error The "https://github.com/jsplumb/jsplumb/raw/1.6.3/dist/js/jquery.jsPlumb-1.6.3-min.js" file could not be downloaded (HTTP/2 404 ). This is because the repository containing that file has moved.

This PR fixes this by updating the jsPlumb dependency to the latest version, 6.2.10.

jpPlumb is now installed via NPM instead of Composer.

This PR also updates the licensing information to specify that the dependency is jsPlumb Community edition and to link to its new GitHub repository containing the licensing information.

This PR also updates the .eslintrc.json file in the html directory to use ES6 for syntax checking.

Tests performed

I tested installing the module on my port on xdmod-dev using the update-open-xdmod-portal.php script and confirmed the flow chart appears correctly in the SUPReMM Dataflow tab in the internal dashboard.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aaronweeden aaronweeden added this to the 11.0.0 milestone Jan 30, 2024
@aaronweeden aaronweeden force-pushed the update-jsplumb branch 4 times, most recently from 4397332 to 60185a3 Compare January 30, 2024 21:19
@ryanrath ryanrath mentioned this pull request Feb 2, 2024
6 tasks
@aaronweeden aaronweeden force-pushed the update-jsplumb branch 3 times, most recently from c40986d to b1b64df Compare February 5, 2024 16:29
@aaronweeden aaronweeden merged commit 7d71287 into ubccr:xdmod11.0 Feb 14, 2024
@aaronweeden aaronweeden deleted the update-jsplumb branch February 14, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants