Add ability to add additional database migration classes. #1991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't thinkit is a good idea to hardcode submodule names into the core. How about just have the code detect any database migrations classes and run them automatically. (run the additional migrations in alphabetical order by classname so that migrations are deterministic) |
ddf4a00 to
9420858
Compare
@jpwhite4 I have updated this. |
jpwhite4
approved these changes
Mar 7, 2025
ced7394 to
941d3a3
Compare
aaronweeden
added a commit
to aaronweeden/xdmod
that referenced
this pull request
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to add additional database migration classes by defining them in the same namespace and ending their names with
DatabasesMigration.This is useful for, e.g., ubccr/xdmod-ondemand#84.
Tests performed
I tested ubccr/xdmod-ondemand#84 in tandem with this PR.