Skip to content

cnameIgnoreList backwards logic - matching entries not ignored #3736

@11EJDE11

Description

@11EJDE11

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

https://github.com/gorhill/uBlock/blob/14a9572c86a0a2ea5d9acd90210ce6d95401c992/platform/firefox/vapi-background-ext.js#L290

Should be === true for correct filtering.

A specific URL where the issue occurs.

https://github.com/gorhill/uBlock/blob/14a9572c86a0a2ea5d9acd90210ce6d95401c992/platform/firefox/vapi-background-ext.js#L290

Steps to Reproduce

--

Expected behavior

If a CNAME hostname matches any entry in cnameIgnoreList, UBO should skip re-running the request for that hostname (ignore it). If it does not match, the request should continue and be filtered as usual.

Actual behavior

CNAME hostnames not matching the ignore list are skipped (ignored).
CNAME hostnames matching the ignore list are processed normally.

uBO version

1.65.0

Browser name and version

Firefox 141

Operating System and version

Windows 10

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingfixedissue has been addressed

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions