Skip to content

No Large Media setting with 0KB should block all images #543

@brianvanburken

Description

@brianvanburken

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

When I set the "No Large Media" setting to 0KB almost all the images are blocked. Except when the image does not have a content-length header. This is known behaviour as described in #188. But, when someone, like me, inputs 0KB then we want to block all images. Even those without a content-length header. Because an image is always bigger than 0KB. uBlock Origin block even these images.

A specific URL where the issue occurs

Any site that has images that return no content-length header. I came across an image on this site: https://hexdocs.pm/pow/Pow.html.

Steps to Reproduce

  1. Set "No Large Media" to 0KB
  2. Visit a site with images that return no content-length headers. Like: https://hexdocs.pm/pow/Pow.html
  3. Set images not blocked

Expected behavior:

All images blocked with a setting of 0KB

Actual behavior:

Images without content-length headers are not blocked

Your environment

  • uBlock Origin version: 1.18.16
  • Browser Name and version: Google Chrome, version 74.0.3729.108 (Official Build) (64-bit)
  • Operating System and version: macOS Mojave, version 10.14.4

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestfixedissue has been addressed

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions