Skip to content

fix: update shell set and pipefail #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 31, 2024
Merged

fix: update shell set and pipefail #75

merged 6 commits into from
Jan 31, 2024

Conversation

tsuyoshicho
Copy link
Owner

@tsuyoshicho tsuyoshicho commented Jan 31, 2024 •
edited
Loading

  • Using bash in docker
  • set opt and pipefail
  • apk install simplify

@tsuyoshicho tsuyoshicho self-assigned this Jan 31, 2024
github-actions[bot]
github-actions bot reviewed Jan 31, 2024
View reviewed changes
github-actions[bot]
github-actions bot reviewed Jan 31, 2024
View reviewed changes
Dockerfile Outdated
@@ -4,10 +4,10 @@ FROM thinca/vim:latest
ENV REVIEWDOG_VERSION=v0.17.0

RUN wget -O - -q https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh| sh -s -- -b /usr/local/bin/ ${REVIEWDOG_VERSION}
RUN apk --update add git && \
RUN apk --update add git bash && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [hadolint] <DL3018> reported by reviewdog 🐶
Pin versions in apk add. Instead of apk add <package> use apk add <package>=<version>

Dockerfile Outdated
@@ -4,10 +4,10 @@ FROM thinca/vim:latest
ENV REVIEWDOG_VERSION=v0.17.0

RUN wget -O - -q https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh| sh -s -- -b /usr/local/bin/ ${REVIEWDOG_VERSION}
RUN apk --update add git && \
RUN apk --update add git bash && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [hadolint] <DL3019> reported by reviewdog 🐶
Use the --no-cache switch to avoid the need to use --update and remove /var/cache/apk/* when done installing packages

@tsuyoshicho tsuyoshicho added the bump:minor Bump up minor version label Jan 31, 2024
github-actions[bot]
github-actions bot reviewed Jan 31, 2024
View reviewed changes
Dockerfile
RUN apk --update add git && \
rm -rf /var/lib/apt/lists/* && \
rm /var/cache/apk/*
RUN apk add --no-cache git bash && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [hadolint] <DL3018> reported by reviewdog 🐶
Pin versions in apk add. Instead of apk add <package> use apk add <package>=<version>

@tsuyoshicho tsuyoshicho merged commit 897b52e into master Jan 31, 2024
@tsuyoshicho tsuyoshicho deleted the fix/bashset branch January 31, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@tsuyoshicho tsuyoshicho

Labels
bump:minor Bump up minor version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tsuyoshicho