Skip to content

feat: Support assuming a role with MFA token #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2019
Merged

feat: Support assuming a role with MFA token #18

merged 1 commit into from
Oct 23, 2019

Conversation

koooge
Copy link
Contributor

@koooge koooge commented Oct 23, 2019

Hi. I got an error wiht MFA due to not supported it.

panic: AssumeRoleTokenProviderNotSetError: assume role with MFA enabled, but AssumeRoleTokenProvider session option not set.

This PR gives AssumeRoleTokenProvider to the session.
https://docs.aws.amazon.com/sdk-for-go/api/aws/session/

looks this:

$ go run main.go --profile hoge edit s3://path/to/file
Assume Role MFA token code:

@koooge
feat: Support assuming a role with MFA token
b4994ec 
Signed-off-by: koooge <koooooge@gmail.com>
tsub
tsub approved these changes Oct 23, 2019
View reviewed changes
Copy link
Owner

@tsub tsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for PR!
It worked as expected. LGTM 😄

@tsub tsub merged commit 6a92c1a into tsub:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsub tsub tsub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koooge @tsub