Skip to content

Fix degradation in 3130bfe #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2018
Merged

Fix degradation in 3130bfe #15

merged 1 commit into from
Aug 23, 2018

Conversation

tsub
Copy link
Owner

@tsub tsub commented Aug 23, 2018 •
edited
Loading

Why?

$AWS_PROFILE is not worked.

$ AWS_PROFILE=myprofile aws configure get region
ap-northeast-1
$ AWS_PROFILE=myprofile s3-edit edit s3://tsub-sandbox/test.txt
MissingRegion: could not find region configuration

$ AWS_PROFILE=myprofile AWS_REGION=ap-northeast-1 s3-edit edit s3://tsub-sandbox/test.txt
NoCredentialProviders: no valid providers in chain. Deprecated.
        For verbose messaging see aws.Config.CredentialsChainVerboseErrors

How?

Do not specify default profile when --profile is not set.

$ AWS_PROFILE=myprofile go run main.go edit s3://tsub-sandbox/test.txt # is working

$ AWS_PROFILE=myprofile aws configure get region
ap-northeast-1

@tsub
Fix degradation in 3130bfe
cb5d6b9 
`$AWS_PROFILE` is not used
@tsub tsub self-assigned this Aug 23, 2018
@tsub tsub merged commit bbca85c into master Aug 23, 2018
@tsub tsub deleted the fixup-pr13 branch August 23, 2018 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tsub tsub

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tsub