-
Notifications
You must be signed in to change notification settings - Fork 25
Implemented MSOP-8 #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented MSOP-8 #235
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MustafaMulla29 can you share link of kicad which you are making
@techmannih here's the link, idk for some reason if you click this link it says 404 page not found on GitHub. I suggest just copy and paste the link in new tab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just add test case with using different num_pins
tests/__snapshots__/msop8_h3.32mm_pl1.63mm_pw0.4mm_p1mm.snap.svg
Outdated
Show resolved
Hide resolved
@seveibar @techmannih done! |
cdfee37
to
bcf4b23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MustafaMulla29 you need improve your function like it will as msop8.msop10, msop12, msop16
you can take help from dip as a reference |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
96c917c
to
a091043
Compare
97b5256
to
010e287
Compare
@techmannih you may review now |
@MustafaMulla29 there is not same pad length, pad width and pitch for all variation |
@techmannih Msop12 and msop16 is not loading in the kicad viewer |
f2ebbb0
to
ba3af4a
Compare
@techmannih done! |
@MustafaMulla29 good work! However, I'm pretty sure this won't work with msop10, msop12, msop16. We need to pass functions like msop10, msop12, msop16 in the test, and as a parameter, you can take help from the dip as a reference. |
I'll make changes👍 |
Just add test case for msop10, msop12, msop16 without using other params, not remove exist test case |
But msop10, msop12, msop16 has different parameters sich as height pl, pw, p etc. How will it know its parameters without passing them. |
Yeah, correct. For this, you need to change your implementation |
@techmannih is this fine now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok to me, waiting on @techmannih
I think you forgot to add bounty😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Can you double check all Params in all case. Make sure these all are correct. I m not on laptop right now.
@techmannih already double checked it before pushing |
Nice! Seve will merge. |
/tip $10 |
🎉🎈 @MustafaMulla29 has been awarded $10! 🎈🎊 |
Fixes #234
/claim #234
All the dimensions and reference is from : https://tscircuit.github.io/kicad-viewer/#Package_SO.pretty/MSOP-8_3x3mm_P0.65mm.kicad_mod