Skip to content

Conversation

MustafaMulla29
Copy link
Contributor

@MustafaMulla29 MustafaMulla29 commented Mar 3, 2025

@Anshgrover23 Anshgrover23 requested a review from techmannih March 3, 2025 13:08
Copy link
Collaborator

@techmannih techmannih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MustafaMulla29 can you share link of kicad which you are making

@MustafaMulla29
Copy link
Contributor Author

@MustafaMulla29
Copy link
Contributor Author

https://tscircuit.github.io/kicad-viewer/#Package_SO.pretty/MSOP-8_3x3mm_P0.65mm.kicad_mod

@techmannih here's the link, idk for some reason if you click this link it says 404 page not found on GitHub. I suggest just copy and paste the link in new tab

Copy link
Collaborator

@techmannih techmannih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just add test case with using different num_pins

@MustafaMulla29
Copy link
Contributor Author

@seveibar @techmannih done!

Copy link
Collaborator

@techmannih techmannih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MustafaMulla29 you need improve your function like it will as msop8.msop10, msop12, msop16

@techmannih
Copy link
Collaborator

you can take help from dip as a reference

Copy link
Collaborator

@techmannih techmannih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@MustafaMulla29
Copy link
Contributor Author

@techmannih you may review now

@techmannih
Copy link
Collaborator

techmannih commented Mar 4, 2025

@MustafaMulla29 there is not same pad length, pad width and pitch for all variation
look this is for msop10
measure by this
https://tscircuit.github.io/kicad-viewer/#Package_SO.pretty/MSOP-10_3x3mm_P0.5mm.kicad_mod

@MustafaMulla29
Copy link
Contributor Author

MustafaMulla29 commented Mar 4, 2025

@MustafaMulla29 there is not same pad length, pad width and pitch for all variation look this is for msop10 measure by this https://tscircuit.github.io/kicad-viewer/#Package_SO.pretty/MSOP-10_3x3mm_P0.5mm.kicad_mod

@techmannih Msop12 and msop16 is not loading in the kicad viewer

@techmannih
Copy link
Collaborator

for msop12 kicad link not working
take help from this
image

@techmannih
Copy link
Collaborator

this for msop16
image

@MustafaMulla29
Copy link
Contributor Author

@techmannih done!

@techmannih
Copy link
Collaborator

@MustafaMulla29 good work! However, I'm pretty sure this won't work with msop10, msop12, msop16. We need to pass functions like msop10, msop12, msop16 in the test, and as a parameter, you can take help from the dip as a reference.

@MustafaMulla29
Copy link
Contributor Author

@MustafaMulla29 good work! However, I'm pretty sure this won't work with msop10, msop12, msop16. We need to pass functions like msop10, msop12, msop16 in the test, and as a parameter, you can take help from the dip as a reference.

I'll make changes👍

@techmannih
Copy link
Collaborator

Just add test case for msop10, msop12, msop16 without using other params, not remove exist test case

@MustafaMulla29
Copy link
Contributor Author

Just add test case for msop10, msop12, msop16 without using other params, not remove exist test case

But msop10, msop12, msop16 has different parameters sich as height pl, pw, p etc. How will it know its parameters without passing them.

@techmannih
Copy link
Collaborator

Yeah, correct. For this, you need to change your implementation

@MustafaMulla29
Copy link
Contributor Author

@techmannih is this fine now?

Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me, waiting on @techmannih

@MustafaMulla29
Copy link
Contributor Author

looks ok to me, waiting on @techmannih

I think you forgot to add bounty😅

Copy link
Collaborator

@techmannih techmannih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you double check all Params in all case. Make sure these all are correct. I m not on laptop right now.

@MustafaMulla29
Copy link
Contributor Author

Looks good! Can you double check all Params in all case. Make sure these all are correct. I m not on laptop right now.

@techmannih already double checked it before pushing

@techmannih
Copy link
Collaborator

Nice! Seve will merge.

@seveibar
Copy link
Contributor

seveibar commented Mar 7, 2025

/tip $10

@seveibar seveibar merged commit 07c6e4b into tscircuit:main Mar 7, 2025
4 checks passed
Copy link

algora-pbc bot commented Mar 7, 2025

🎉🎈 @MustafaMulla29 has been awarded $10! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement MSOP-8
3 participants