Skip to content

Fixes #220 #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2025
Merged

Fixes #220 #221

merged 1 commit into from
Mar 13, 2025

Conversation

ryanartecona
Copy link
Contributor

No description provided.

@ryanartecona ryanartecona requested a review from jjlgao March 11, 2025 23:28
@ryanartecona ryanartecona mentioned this pull request Mar 11, 2025
Closed
jjlgao
jjlgao approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@jjlgao jjlgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for watching the issues and doing this! Sorry, the .Values and $.Values thing has bitten me more than once now, I have to think about possibly enforcing usage of $ if it's even possible to do.

@ryanartecona ryanartecona merged commit e0cbd93 into main Mar 13, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjlgao jjlgao jjlgao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanartecona @jjlgao