Skip to content

chore: Move VCT proof checking to observer #1399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2022
Merged

chore: Move VCT proof checking to observer #1399

merged 1 commit into from
Jul 18, 2022

Conversation

sandrask
Copy link
Contributor

Move VCT proof checking from proof and credential handlers to observer. This way it will be checked during onboarding domains etc.

Closes #1317

Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com

@cla-bot cla-bot bot added the cla-signed label Jul 14, 2022
@codecov
Copy link

codecov bot commented Jul 14, 2022 •
edited
Loading

Codecov Report

Merging #1399 (13476e1) into main (7bf7114) will increase coverage by 0.00%.
The diff coverage is 91.48%.

@@           Coverage Diff           @@
##             main    #1399   +/-   ##
=======================================
  Coverage   88.06%   88.06%           
=======================================
  Files         205      205           
  Lines       19092    19086    -6     
=======================================
- Hits        16814    16809    -5     
- Misses       1460     1461    +1     
+ Partials      818      816    -2
Impacted Files Coverage Δ
pkg/observer/observer.go 84.78% <90.69%> (+2.08%) ⬆️
cmd/orb-server/startcmd/start.go 67.28% <100.00%> (-0.33%) ⬇️
...ctivitypub/service/activityhandler/inboxhandler.go 83.25% <100.00%> (ø)
pkg/anchor/handler/credential/handler.go 75.51% <100.00%> (-1.29%) ⬇️
pkg/anchor/handler/proof/handler.go 77.58% <100.00%> (-0.37%) ⬇️
pkg/vct/proofmonitoring/monitoring.go 84.07% <0.00%> (-2.66%) ⬇️
pkg/observer/pubsub.go 94.49% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bf7114...13476e1. Read the comment docs.

@sandrask sandrask force-pushed the issue-1317 branch 3 times, most recently from 9f4ad45 to a47e0f8 Compare July 15, 2022 13:01
@sandrask sandrask changed the title chore: Move VCT proof checking to observer wip: Move VCT proof checking to observer Jul 15, 2022
@sandrask sandrask force-pushed the issue-1317 branch 2 times, most recently from 95c6ccb to 8dfc042 Compare July 15, 2022 18:43
@sandrask sandrask force-pushed the issue-1317 branch 2 times, most recently from 56cb06f to 3ee6d5f Compare July 15, 2022 19:53
@sandrask sandrask changed the title wip: Move VCT proof checking to observer chore: Move VCT proof checking to observer Jul 18, 2022
@sandrask sandrask linked an issue Jul 18, 2022 that may be closed by this pull request
VCT proof monitoring expiry time #1398
Closed
@sandrask
chore: Move VCT proof checking to observer
13476e1 
Move VCT proof checking from proof and credential handlers to observer. This way it will be checked during onboarding domains etc.

Closes trustbloc#1317

Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
@sandrask sandrask merged commit 4492bd3 into trustbloc:main Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fqutishat fqutishat fqutishat approved these changes

@bstasyszyn bstasyszyn bstasyszyn approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VCT proof monitoring expiry time Observer should monitor for proofs being included in VCT log
3 participants
@sandrask @fqutishat @bstasyszyn